You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/03/31 04:22:28 UTC

[GitHub] [spark] yaooqinn commented on a diff in pull request #40583: [SPARK-42955][SQL] Skip classifyException and wrap AnalysisException for SparkThrowable

yaooqinn commented on code in PR #40583:
URL: https://github.com/apache/spark/pull/40583#discussion_r1153995742


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java:
##########
@@ -628,6 +630,16 @@ public int hashCode() {
       result = 31 * result + Arrays.hashCode(fieldNames);
       return result;
     }
+
+    @Override
+    public String toString() {

Review Comment:
   https://github.com/apache/spark/pull/40583/files#diff-8d2ca0d05dd54468ef4faf6ae318ed2288c46be701f3858eecbb371c8f0d420bR343 OK, I will break the test part to line-to-line comparison.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org