You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/06/12 15:59:31 UTC
[GitHub] [superset] kgabryje opened a new pull request, #24362: chore: Disable redux errors
kgabryje opened a new pull request, #24362:
URL: https://github.com/apache/superset/pull/24362
### SUMMARY
Due to long standing issues with Superset's redux store, recently introduced redux-toolkit produces hundreds of console errors related to violating state immutability and saving un-serializable objects. Though the errors are accurate, they make development work harder due to cluttering the browser console. This PR disables the Redux middleware responsible for issuing those errors by default.
If you'd like to enable those errors to work on improving the Redux state, you can do that by setting env variable `REDUX_DEFAULT_MIDDLEWARE` to true. To do that, you can run frontend with the following script:
`REDUX_DEFAULT_MIDDLEWARE=true npm run dev-server`
or
```
export REDUX_DEFAULT_MIDDLEWARE=true
npm run dev-server
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24362: chore: Disable redux errors
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24362:
URL: https://github.com/apache/superset/pull/24362#issuecomment-1587718027
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24362](https://app.codecov.io/gh/apache/superset/pull/24362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5cf6ce1) into [master](https://app.codecov.io/gh/apache/superset/commit/e0253a4b2572045643de4b824875a8f366db4254?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0253a4) will **decrease** coverage by `0.01%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 5cf6ce1 differs from pull request most recent head 543e6ef. Consider uploading reports for the commit 543e6ef to get more accurate results
```diff
@@ Coverage Diff @@
## master #24362 +/- ##
==========================================
- Coverage 69.04% 69.04% -0.01%
==========================================
Files 1903 1903
Lines 74564 74565 +1
Branches 8107 8108 +1
==========================================
Hits 51485 51485
Misses 20968 20968
- Partials 2111 2112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.61% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/store.ts](https://app.codecov.io/gh/apache/superset/pull/24362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3N0b3JlLnRz) | `75.00% <50.00%> (-3.27%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #24362: chore: Disable redux errors
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #24362:
URL: https://github.com/apache/superset/pull/24362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org