You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/05/30 09:10:10 UTC

[GitHub] zeppelin pull request #2378: [ZEPPELIN-2602] fix: broken navbar-title render...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2378

    [ZEPPELIN-2602] fix: broken navbar-title rendering in safari

    ### What is this PR for?
    
    fix: broken navbar-title rendering in safari.
    
    I attached screenshots.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2602]()
    
    ### How should this be tested?
    
    1. Clone apache/zeppelin
    2. Build `mvn clean package -DskipTests;`
    3. Open `localhost:8080` in **Safari**
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    #### After
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/26576191/e9db8f4c-4562-11e7-9677-215140f0c852.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2602/navbar-is-broken-in-safari

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2378
    
----
commit d46008bfe986ddd075888b4a2f6e040de5d4724c
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-30T09:06:46Z

    fix: navbar-title rendering in safari

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2378: [ZEPPELIN-2602] fix: broken navbar-title rendering in ...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2378
  
    LGTM and merge to master if no further comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2378: [ZEPPELIN-2602] fix: broken navbar-title render...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2378


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---