You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/28 17:59:46 UTC

[GitHub] [geode] pivotal-jbarrett opened a new pull request #7060: Replace inconsistent use of Integer and int with BucketId.

pivotal-jbarrett opened a new pull request #7060:
URL: https://github.com/apache/geode/pull/7060


   <!-- Thank you for submitting a contribution to Apache Geode. -->
   
   <!-- In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken: 
   -->
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-1007878211


   This pull request **introduces 3 alerts** and **fixes 1** when merging 6796248c520f4cbc9eb36d4a89f002797856477a into 87c32e4b85d5b5150a5290ab1e7f1919020e4bf9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-3bf0b2c63930ba267a3fbec27f3279cbd1a42c26)
   
   **new alerts:**
   
   * 3 for Useless null check
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-955149263


   This pull request **introduces 1 alert** and **fixes 1** when merging b6d7bb295d0653b4de261d8e97417953a73a1efe into 3b88dfbf39b16e7561ba0f6e0ac5fee46cd9a15c - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-84ae6bc0c87d7210841f988932bb54f01c64dd5e)
   
   **new alerts:**
   
   * 1 for Missing space in string literal
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-955098561


   This pull request **introduces 1 alert** and **fixes 1** when merging 9c27d7775afb8c6572853acdde167ea88cd0da27 into 22577d73fba46ee4724c1d17e8b7d228c622907a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-8ff1204169f3d03aec0eb348fa90373589d91f71)
   
   **new alerts:**
   
   * 1 for Missing space in string literal
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-1007878211


   This pull request **introduces 3 alerts** and **fixes 1** when merging 6796248c520f4cbc9eb36d4a89f002797856477a into 87c32e4b85d5b5150a5290ab1e7f1919020e4bf9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-3bf0b2c63930ba267a3fbec27f3279cbd1a42c26)
   
   **new alerts:**
   
   * 3 for Useless null check
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-978246616


   This pull request **fixes 1 alert** when merging f80383c898eddf3e2e5c17d69137479d01d22ae6 into aca053b21a9dc74e9bb79fa52a9cd47a12e110e2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-60f4422803732f7a0332d187d86170f53ce97568)
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-955795517


   This pull request **introduces 1 alert** and **fixes 1** when merging 13fb169ed73b932e3e1457cc3f67d1ca39ba3278 into adc2e717b18cd45237de3be75f251269ff6bbb3f - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-b2c76fc5e84716cd2bcfa6ba664c6b8af1acd198)
   
   **new alerts:**
   
   * 1 for Missing space in string literal
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-1054923738


   This pull request **introduces 3 alerts** and **fixes 12** when merging 512d7d97cd98b22357f975734526909dd727a918 into 5ed8bd9378f6f13c803226a873fae6891d0a51ed - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-cff41216eab84cdde94d250de924934805b9f310)
   
   **new alerts:**
   
   * 2 for Useless null check
   * 1 for Inefficient output stream
   
   **fixed alerts:**
   
   * 9 for Cast from abstract to concrete collection
   * 2 for Dereferenced variable may be null
   * 1 for Boxed variable is never null


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-954104076


   This pull request **introduces 9 alerts** and **fixes 1** when merging 2d781ce26ccadcfdcc35aba72fe4f09fe8e9c7b6 into dae7b820812632854f634d4a2c62bd84ed6c6a6c - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-8afb5977273482dd6521bd8f2f8aece6a9acb632)
   
   **new alerts:**
   
   * 9 for Type mismatch on container access
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] lgtm-com[bot] commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7060:
URL: https://github.com/apache/geode/pull/7060#issuecomment-981966626


   This pull request **fixes 1 alert** when merging 7ca92328f5abfbf55d388c2ca5724e8459624d03 into 87e3017d57b46174ca949de69f598386bab7d4d1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-644115a4b3f39d5490a244e225f60950116ef525)
   
   **fixed alerts:**
   
   * 1 for Cast from abstract to concrete collection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org