You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/11 04:47:09 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1554: Add support for hard links to CROMFS

xiaoxiang781216 commented on a change in pull request #1554:
URL: https://github.com/apache/incubator-nuttx/pull/1554#discussion_r468287907



##########
File path: fs/cromfs/fs_cromfs.c
##########
@@ -1213,7 +1449,8 @@ static int cromfs_stat(FAR struct inode *mountpt, FAR const char *relpath,
                        FAR struct stat *buf)
 {
   FAR const struct cromfs_volume_s *fs;
-  FAR const struct cromfs_node_s *node;
+  FAR struct cromfs_nodeinfo_s info;

Review comment:
       remove FAR?

##########
File path: fs/cromfs/fs_cromfs.c
##########
@@ -491,8 +716,9 @@ static int cromfs_open(FAR struct file *filep, FAR const char *relpath,
 {
   FAR struct inode *inode;
   FAR const struct cromfs_volume_s *fs;
-  FAR const struct cromfs_node_s *node;
+  FAR struct cromfs_nodeinfo_s info;

Review comment:
       remove FAR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org