You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/16 15:57:24 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9310:
Fixes #9085 - Add global install of webpack and webpack-cli to docker-compose
willbarrett opened a new pull request #9310: Fixes #9085 - Add global install of webpack and webpack-cli to docker-compose
URL: https://github.com/apache/incubator-superset/pull/9310
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
`npm` being the unreliable system it is, it occasionally fails to make the `webpack` executable available when building the node container under `docker-compose`. This PR installs `webpack` and `webpack-cli` globally to avoid this problem. Solution suggested by @saltict in response to https://github.com/apache/incubator-superset/issues/9085.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/incubator-superset/issues/9085
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@rusackas @craig-rueda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rc-ontruck commented on issue #9310: Fixes
#9085 - Add global install of webpack and webpack-cli to docker-compose
Posted by GitBox <gi...@apache.org>.
rc-ontruck commented on issue #9310: Fixes #9085 - Add global install of webpack and webpack-cli to docker-compose
URL: https://github.com/apache/incubator-superset/pull/9310#issuecomment-599663092
Seen that there are a duplicate entry on this PR code, I see two times npm install request.
&& npm install --global webpack webpack-cli && npm install &&
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9310: Fixes
#9085 - Add global install of webpack and webpack-cli to docker-compose
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9310: Fixes #9085 - Add global install of webpack and webpack-cli to docker-compose
URL: https://github.com/apache/incubator-superset/pull/9310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org