You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2009/10/14 12:30:06 UTC

Re: [jira] Commented: (LUCENE-1974) BooleanQuery can not find all matches in special condition

I just tried this (I increased the numDeletedDocs by adding 10000 to
the original counts), but it doesn't hit this bug, I believe because
all the deleted docs are created after the real docs.

It does provoke new failures, but they all seem to be false failures
[floating point precision issues], eg:

    [junit]  expected:<1379.988> but was:<1379.9883>

Also, the bug only happens when a  BooleanQuery has a clause whose
Query falls back to Scorer.score(Collector, int, int).  EG TermQuery
has it's own [correct] impl for that, but PrefixQuery does not, so a
BQ with a PrefixQuery clause will hit it.  Plus the BQ must have only
SHOULD and up to 32 MUST_NOT clauses (so that it uses BooleanScorer
not BooleanScorer2).

I'm trying to modify TestBoolean2 so that it takes the tiny (4 doc)
index it's using, and multiplies it up to 16K docs, and then verifies
that each query finds 4K * the number of matches.  But so far I can't
get that test to fail either... still digging.

Mike

On Tue, Oct 13, 2009 at 10:11 PM, Chris Hostetter
<ho...@fucit.org> wrote:
>
> : I think the other tests do not catch it because the error only happens
> : if the docID is over 8192 (the chunk size that BooleanScorer uses).
> : Most of our tests work on smaller sets of docs.
>
> I don't have time to try this out right now, but i wonder if just
> modifying the QueryUtils wrap* functions to create bigger "empty" indexes
> (with thousands of deleted docs instead of just a handful) would have
> triggered this bug ... might be worth testing against 2.9.0 to make sure
> there aren't any other weird edge cases before cutting 2.9.1.
>
>
> -Hoss
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org