[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer

["Thomas Andraschko (Jira)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752075#comment-17752075 ] 

Thomas Andraschko commented on MYFACES-4536:
--------------------------------------------

[~melloware] is there anything to do here in MF? ITs are running fine since we removed 2.2 and the old constructor?

> PartialResponseWriter: Do no wrap the writer
> --------------------------------------------
>
>                 Key: MYFACES-4536
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4536
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>            Reporter: Melloware
>            Assignee: Melloware
>            Priority: Major
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been deprecated in order to force implementors to instead use the constructor taking the wrapped instance (and to raise their awareness), so that logically the inherited {{getWrapped()}} method will be used throughout the implementation instead of the local {{wrapped}} variable. This will ensure that the correct implementation is returned and correct behavior is performed might the {{FacesWrapper}} implementation itself being wrapped by yet another {{FacesWrapper}} implementation further down the chain. Because, when the {{FacesWrapper}} implementation incorrectly/accidentally uses the local {{wrapped}} variable instead of the {{getWrapped()}} method, then that other {{FacesWrapper}} implementation will basically be completely ignored, hereby breaking the decorator pattern.
>  
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518



--
This message was sent by Atlassian Jira
(v8.20.10#820010)