You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/18 08:29:50 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #13437: [Improvement](decimal) print decimal according to the real precision and scale
Gabriel39 opened a new pull request, #13437:
URL: https://github.com/apache/doris/pull/13437
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1286359396
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1283242089
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] LOVEGISER commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
LOVEGISER commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1283456743
i have test，this is great
`
CREATE TABLE `test` (
`id` varchar(32) NULL DEFAULT "",
`user_name` varchar(32) NULL DEFAULT "",
`member_list` DECIMAL(10,3)
) ENGINE=OLAP
DUPLICATE KEY(`id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`id`) BUCKETS 10
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2",
"disable_auto_compaction" = "false"
);
INSERT INTO test VALUES ('2','sim',1.000);
INSERT INTO test VALUES ('2','sim',1.001);
INSERT INTO test VALUES ('2','sim',1.002);
mysql> select * from test;
+------+-----------+-------------+
| id | user_name | member_list |
+------+-----------+-------------+
| 2 | sim | 1.002 |
| 2 | sim | 1.001 |
| 2 | sim | 1.000 |
mysql> select cast(avg(member_list) as DECIMAL(10,3)) from test;
+-------------------------------------------+
| CAST(avg(`member_list`) AS DECIMAL(10,3)) |
+-------------------------------------------+
| 1.000 |
+-------------------------------------------+
1 row in set (0.02 sec)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
dataroaring commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1285078312
We should update result for p2 cases too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1285497979
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.88 seconds
load time: 570 seconds
storage size: 17154602757 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020205802_clickbench_pr_32113.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13437:
URL: https://github.com/apache/doris/pull/13437#issuecomment-1283242195
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13437: [Improvement](decimal) print decimal according to the real precision and scale
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13437:
URL: https://github.com/apache/doris/pull/13437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org