You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/10/21 19:32:15 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-905 Harden time orien...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/117
TINKERPOP3-905 Harden time oriented tests in ResultQueueTest
https://issues.apache.org/jira/browse/TINKERPOP3-905
Now that the test relies on a CountDownLatch to explicitly block until a specified number of items are in the queue, the test should not randomly fail if items are slow to get to that queue.
If you've seen this test fail before please run the standard `mvn clean install` test suite.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 18e5ccad6e8153623da41ff6ecde79aa285caf34
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-10-21T17:22:40Z
TINKERPOP3-905 Refactored ResultQueueTest to not rely on Thread.sleep().
Now that the test relies on a CountDownLatch to explicitly block until a specified number of items are in the queue, the test should not randomly fail if items are slow to get to that queue.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-905 Harden time orien...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-905 Harden time orien...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/117#issuecomment-149985941
I ran `mvn clean install` twice. No issues.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-905 Harden time orien...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/117#issuecomment-150159158
Forgot my own vote for +1 - that's 3 - I'll get this merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-905 Harden time orien...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/117#issuecomment-150027914
Looks good on my machine too.
Another +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---