You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/07/30 19:31:31 UTC
[GitHub] [gobblin] autumnust opened a new pull request #3347: [GOBBLIN-1501] Documentation + Code Cleaning for IcebergMetadataWriter
autumnust opened a new pull request #3347:
URL: https://github.com/apache/gobblin/pull/3347
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1501
### Description
This PR mostly adds documentation, renaming and fixing typo in the `gobblin-icberg` module, with extra focus on `IcebergMetadataWriter` for:
- Change the way that `Transaction` object is initialized as it is shared in many different places.
- Change the way for accessing or initializing `AppendFiles` and `DeleteFiles` object. All these changes in `TableMetadata` object.
- Adding documentation for places where commit does happen or doesn't happen for reasons.
- Remove some of the `IOException` in the method signature wherever they are not required.
### Tests
This PR doesn't add or delete any of the functionality so pass all unit tests should be sufficient.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] autumnust commented on pull request #3347: [GOBBLIN-1501] Documentation + Code Cleaning for IcebergMetadataWriter
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3347:
URL: https://github.com/apache/gobblin/pull/3347#issuecomment-890109220
@ZihanLi58 Can you please take a look when you got a chance? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] autumnust merged pull request #3347: [GOBBLIN-1501] Documentation + Code Cleaning for IcebergMetadataWriter
Posted by GitBox <gi...@apache.org>.
autumnust merged pull request #3347:
URL: https://github.com/apache/gobblin/pull/3347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org