You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/22 02:52:39 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8278: change RDLBackendHandler.getRowData return type from List to Collection
codecov-io commented on pull request #8278:
URL: https://github.com/apache/shardingsphere/pull/8278#issuecomment-731682032
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=h1) Report
> Merging [#8278](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=desc) (aae10a3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/59177804f5876542dcc560170e5c1986754f6210?el=desc) (5917780) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8278/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8278 +/- ##
============================================
+ Coverage 74.63% 74.70% +0.06%
+ Complexity 602 600 -2
============================================
Files 1483 1483
Lines 23476 23434 -42
Branches 4176 4174 -2
============================================
- Hits 17522 17507 -15
+ Misses 4806 4774 -32
- Partials 1148 1153 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/proxy/backend/text/admin/RDLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1JETEJhY2tlbmRIYW5kbGVyLmphdmE=) | `91.48% <ø> (+1.90%)` | `0.00 <0.00> (ø)` | |
| [...jdbc/core/connection/ShardingSphereConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ1NwaGVyZUNvbm5lY3Rpb24uamF2YQ==) | `64.51% <0.00%> (-20.49%)` | `1.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...dingsphere/scaling/postgresql/wal/WalPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC93YWwvV2FsUG9zaXRpb24uamF2YQ==) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
| [...osition/resume/ResumeBreakPointManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL1Jlc3VtZUJyZWFrUG9pbnRNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
| [...ingsphere/scaling/mysql/binlog/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2JpbmxvZy9CaW5sb2dQb3NpdGlvbi5qYXZh) | `80.00% <0.00%> (-8.89%)` | `0.00% <0.00%> (ø%)` | |
| [...ling/core/job/position/InventoryPositionGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vSW52ZW50b3J5UG9zaXRpb25Hcm91cC5qYXZh) | `92.85% <0.00%> (-7.15%)` | `1.00% <0.00%> (ø%)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
| [.../scaling/mysql/component/MySQLPositionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTFBvc2l0aW9uTWFuYWdlci5qYXZh) | `77.77% <0.00%> (-6.10%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ostgresql/component/PostgreSQLPositionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC9jb21wb25lbnQvUG9zdGdyZVNRTFBvc2l0aW9uTWFuYWdlci5qYXZh) | `75.75% <0.00%> (-4.80%)` | `0.00% <0.00%> (-1.00%)` | |
| [...b/preparer/splitter/InventoryDataTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvc3BsaXR0ZXIvSW52ZW50b3J5RGF0YVRhc2tTcGxpdHRlci5qYXZh) | `88.05% <0.00%> (-4.48%)` | `0.00% <0.00%> (ø%)` | |
| ... and [73 more](https://codecov.io/gh/apache/shardingsphere/pull/8278/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=footer). Last update [5917780...aae10a3](https://codecov.io/gh/apache/shardingsphere/pull/8278?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org