You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2014/11/17 11:53:25 UTC

Re: Commit of table work

Hi guys,

Can you update us on the status and "planning" (note the quotes, the
project doesn't require any schedule) of your contributions?

Thanks,

EdB



On Wed, Oct 29, 2014 at 12:13 PM, piotrz <pi...@gmail.com> wrote:

> Thanks Erik! :)
>
> Harbs I've sent you an invitation on skype.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p41913.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

For sure TableTests won't work and They should be completle rewrite. I could
prepare some shape for such tests and based on this shape show you where you
can put your tests logic. 

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42703.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

If you think that preparing such shape it is a good idea please send here
list of class which you have created and which you potentially want to test.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42704.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I just poked through the tests a bit. The TableTests are definitely not going to work. They look like they were written for the old Table architecture. The class names do not even match.

I should rewrite the tests to work on tables, but I have no idea how the tests are supposed to work.

Is there a primer on how FlexUnit is supposed to be working?

On Nov 24, 2014, at 11:33 AM, piotrz <pi...@gmail.com> wrote:

> Hi Harbs,
> 
> That is great!! 
> 
> Before the merge with your branch I had everything set up in my IDE Intellij
> and was able to build project and debug, but now I can't figure out why it
> doesn't work. That's why I've added to our ant script ability to build
> project in debug mode. :)
> In build.properties you have to set:
> 
> minimalTests = true (to run all tests)
> flexdebug = true (to have ability to debug tests)
> 
> Note one thing if you have run one selected tests you can add it to:
> MinimalTestsSuite.as and all runnuble tests are in AllTestsSuite.as
> 
> As for debug - Once you build by ant flex unit app with flexdebug mode, you
> have to run in your IDE 
> 
> 1) debug listening
> 2) run tlf flex unit app using Vellum
> flex-tlf/bin/apps/automation_apps/bin/VellumUnit.html
> 
> Piotr
> 
> 
> 
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42701.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Hi Harbs,

That is great!! 

Before the merge with your branch I had everything set up in my IDE Intellij
and was able to build project and debug, but now I can't figure out why it
doesn't work. That's why I've added to our ant script ability to build
project in debug mode. :)
In build.properties you have to set:

minimalTests = true (to run all tests)
flexdebug = true (to have ability to debug tests)

Note one thing if you have run one selected tests you can add it to:
MinimalTestsSuite.as and all runnuble tests are in AllTestsSuite.as

As for debug - Once you build by ant flex unit app with flexdebug mode, you
have to run in your IDE 

1) debug listening
2) run tlf flex unit app using Vellum
flex-tlf/bin/apps/automation_apps/bin/VellumUnit.html

Piotr






-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42701.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
Hi Piotr,

I fixed the bug that was causing the vast majority of the errors. Currently there’s no errors, but six failures in FloatTest:


[flexunit] Suite: UnitTest.Tests.FloatTest
 [flexunit] Tests run: 56, Failures: 6, Errors: 0, Skipped: 1, Time elapsed: 22.253 sec
 [flexunit] 
 [flexunit] Results :
 [flexunit] 
 [flexunit] Tests run: 56, Failures: 6, Errors: 0, Skipped: 1, Time elapsed: 22.253 sec
 [flexunit] 


All six failures appear to be an issue with the vertical positioning of floats.

Is there a way I can debug these tests to find where it’s going wrong?

Also, how do I run the rest of the tests to make sure there’s no more failures?

On Nov 19, 2014, at 12:18 AM, piotrz <pi...@gmail.com> wrote:

> Harbs,
> 
> I did quick look into the errors of failing tests. I don't know what could
> be the cause of this errors - you have to look into that on your own. :/
> 
> Class FloatTest - every test in this class is failing with the same error:
> 
> http://paste.ofcode.org/VJTfQaGaDgxeGnyRXg8jKu
> 
> Try to analize for example this test -> rightBigIndent - This is one of the
> failed method. 
> 
> To run only FloatTest and see what is happened you have to:
> 
> 1) In build.properties file set up
> 
> minimalTests = true 
> flexdebug = false - only if you want debuggable swf
> 
> 2) Setup in env.properties file FLEX_HOME path
> 
> 3) Run the tests using ant "all" target
> 
> Once the tests finished you will find xml report file in this location:
> 
> flex-tlf\bin\apps\automation_apps\bin\TEST-UnitTest.Tests.FloatTest.xml
> 
> Piotr
> 
> 
> 
> 
> 
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42486.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
It’s running now.

There was a commit to the tables branch that I did not notice. I pulled that commit and it’s working now.

How do I step into the debugger to see what’s failing?

On Nov 20, 2014, at 11:27 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:

> I have set FLEX_HOME as an environment variable for all instances of Bash
> (the command line/terminal). So I'm not using the env.properties file ...
> 
> All I did was make my branch 'tables' the HEAD, pull to make it up to date,
> and run 'ant all'.
> 
> I'm running Java version 1.7.0_67, not the Mac 'built in' one, maybe that
> is causing problems for Harbs?
> 
> EdB
> 
> 
> 
> On Thu, Nov 20, 2014 at 10:07 AM, piotrz <pi...@gmail.com> wrote:
> 
>> Thanks Erik.
>> Tests launched for you it's good but now I am wondering what's is the diff
>> between your environment and Harbs that on his Mac they didn't launch.
>> 
>> As for this errors this is something what we are trying to resolve, that's
>> why I wanted to Harbs launch the tests.
>> 
>> Piotr
>> 
>> 
>> 
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context:
>> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42555.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>> 
> 
> 
> 
> -- 
> Ix Multimedia Software
> 
> Jan Luykenstraat 27
> 3521 VB Utrecht
> 
> T. 06-51952295
> I. www.ixsoftware.nl


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
FWIW, the stack trace for almost all the failures is very similar to the error I’m seeing in the other case with threaded text.

There’s a good chance when I fix that, most of these errors will go away.

I had very little time this week to work on that. I’m hoping to be able to tackle that first thing next week.

Harbs

Re: Commit of table work

Posted by Erik de Bruin <er...@ixsoftware.nl>.
I have set FLEX_HOME as an environment variable for all instances of Bash
(the command line/terminal). So I'm not using the env.properties file ...

All I did was make my branch 'tables' the HEAD, pull to make it up to date,
and run 'ant all'.

I'm running Java version 1.7.0_67, not the Mac 'built in' one, maybe that
is causing problems for Harbs?

EdB



On Thu, Nov 20, 2014 at 10:07 AM, piotrz <pi...@gmail.com> wrote:

> Thanks Erik.
> Tests launched for you it's good but now I am wondering what's is the diff
> between your environment and Harbs that on his Mac they didn't launch.
>
> As for this errors this is something what we are trying to resolve, that's
> why I wanted to Harbs launch the tests.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42555.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Thanks Erik. 
Tests launched for you it's good but now I am wondering what's is the diff
between your environment and Harbs that on his Mac they didn't launch. 

As for this errors this is something what we are trying to resolve, that's
why I wanted to Harbs launch the tests.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42555.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Erik de Bruin <er...@ixsoftware.nl>.
The test run reports:

[flexunit] Suite: UnitTest.Tests.FloatTest
[flexunit] Tests run: 56, Failures: 1, Errors: 92, Skipped: 1, Time
elapsed: 5.214 sec

and then the build fails.

EdB



On Thu, Nov 20, 2014 at 9:56 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:

> Thanks.
>
> I get a 'good' run, but for the tests I get (literally) 92 errors like
> this one:
>
> [flexunit] FlexUnit test [variable] in suite UnitTest.Tests.FloatTest had
> errors.
>
> Where [variable] is 92 instance or classNames like:
> "composeAcrossControllers"
>
> Is that expected?
>
> EdB
>
>
>
>
> On Thu, Nov 20, 2014 at 9:44 AM, piotrz <pi...@gmail.com> wrote:
>
>> Hi Erik,
>>
>> This is the steps for launch tests:
>>
>> 1) In tlf folder - build.properties file set up
>>
>> minimalTests = true
>> flexdebug = false - only if you want debuggable swf
>>
>> 2) Create env.properties file in tlf folder and add there FLEX_HOME path
>>
>> 3) Run the tests using ant "all" target
>>
>> Thank you. Let me know if you will be having any problems.
>>
>>
>>
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context:
>> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42549.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by Erik de Bruin <er...@ixsoftware.nl>.
Thanks.

I get a 'good' run, but for the tests I get (literally) 92 errors like this
one:

[flexunit] FlexUnit test [variable] in suite UnitTest.Tests.FloatTest had
errors.

Where [variable] is 92 instance or classNames like:
"composeAcrossControllers"

Is that expected?

EdB




On Thu, Nov 20, 2014 at 9:44 AM, piotrz <pi...@gmail.com> wrote:

> Hi Erik,
>
> This is the steps for launch tests:
>
> 1) In tlf folder - build.properties file set up
>
> minimalTests = true
> flexdebug = false - only if you want debuggable swf
>
> 2) Create env.properties file in tlf folder and add there FLEX_HOME path
>
> 3) Run the tests using ant "all" target
>
> Thank you. Let me know if you will be having any problems.
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42549.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Hi Erik,

This is the steps for launch tests:

1) In tlf folder - build.properties file set up 

minimalTests = true 
flexdebug = false - only if you want debuggable swf 

2) Create env.properties file in tlf folder and add there FLEX_HOME path 

3) Run the tests using ant "all" target 

Thank you. Let me know if you will be having any problems.



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42549.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Erik de Bruin <er...@ixsoftware.nl>.
I can run the tests. What do I launch?

EdB



On Thu, Nov 20, 2014 at 9:24 AM, piotrz <pi...@gmail.com> wrote:

> Harbs,
>
> I will be having next free cycles on Monday. It would be great if anyone
> who
> use Mac OSX could try to launch Unit Tests in tlf from Harbs's tables
> branch
> earlier. I just wanted to confirm whether this is something specific for
> his
> environment or not.
>
> Thanks,
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42547.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

I will be having next free cycles on Monday. It would be great if anyone who
use Mac OSX could try to launch Unit Tests in tlf from Harbs's tables branch
earlier. I just wanted to confirm whether this is something specific for his
environment or not.

Thanks,
Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42547.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
For some reason tests didn't launch. I have to analyze your ant output and
compare with mine.

I see that Flow.swf launched without a problem - This is module you can see
at the bottom.

Pete 



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42508.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I don’t see any progress.

Here’s what I see:
https://www.evernote.com/shard/s143/sh/0264fd2e-1d63-4887-9a9f-a4c8a8103238/184e2fee807124f8f0b29694c69ff569

I feel like I’m groping in the dark. I have no idea what any of this is doing…

On Nov 19, 2014, at 11:09 AM, piotrz <pi...@gmail.com> wrote:

> Did tests start ? Or there is no progress ? 
> 
> bin\apps\automation_apps\bin\ - Do you have in this location html wrapper
> for VellumUnit.swf ? You could try to launch it in web browser to see
> whether tests are launching.
> 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42506.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Did tests start ? Or there is no progress ? 

bin\apps\automation_apps\bin\ - Do you have in this location html wrapper
for VellumUnit.swf ? You could try to launch it in web browser to see
whether tests are launching.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42506.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I changed the default app on my machine to open swf files to the Flash Player Debugger.

I got further now, but I don’t think I got as far as you:

flexunnit_tests:
 [flexunit] Validating task attributes ...
 [flexunit] Generating default values ...
 [flexunit] Using default working dir [/Users/harbs/Documents/ApacheFlex/flex-tlf]
 [flexunit] Using the following settings for the test run:
 [flexunit] 	FLEX_HOME: [/Users/harbs/Documents/ApacheFlex/flex-tlf/../flex-sdk]
 [flexunit] 	haltonfailure: [true]
 [flexunit] 	headless: [false]
 [flexunit] 	display: [99]
 [flexunit] 	localTrusted: [true]
 [flexunit] 	player: [flash]
 [flexunit] 	port: [1024]
 [flexunit] 	swf: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf]
 [flexunit] 	timeout: [60000ms]
 [flexunit] 	toDir: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin]
 [flexunit] Setting up server process ...
 [flexunit] Starting server ...
 [flexunit] Entry [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin] already available in local trust file at [/Users/harbs/Library/Preferences/Macromedia/Flash Player/#Security/FlashPlayerTrust/flexUnit.cfg].
 [flexunit] Executing 'open' with arguments:
 [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
 [flexunit] 
 [flexunit] The ' characters around the executable and arguments are
 [flexunit] not part of the command.
 [flexunit] 
 [flexunit] Opening server socket on port [1024].
 [flexunit] Waiting for client connection ...
 [flexunit] Client connected.
 [flexunit] Setting inbound buffer size to [262144] bytes.
 [flexunit] Receiving data ...
 [flexunit] Sending acknowledgement to player to start sending test data ...
 [flexunit] 
 [flexunit] FlexUnit test draggingSelectioinMultiFlows in suite UnitTest.Tests.ContainerTypeTest was ignored.
 [flexunit] FlexUnit test autoAndDragScrollingTest in suite UnitTest.Tests.ContainerTypeTest failed.
 [flexunit] FlexUnit test addRemoveMulitiLinkedContainerTest in suite UnitTest.Tests.ContainerTypeTest had errors.
 [flexunit] 
 [flexunit] Stopping server ...
 [flexunit] End of test data reached, sending acknowledgement to player ...
 [flexunit] Closing client connection ...
 [flexunit] Closing server on port [1024] ...
 [flexunit] Analyzing reports ...
 [flexunit] 
 [flexunit] Suite: UnitTest.Tests.ContainerTypeTest
 [flexunit] Tests run: 22, Failures: 1, Errors: 1, Skipped: 1, Time elapsed: 0.364 sec
 [flexunit] 
 [flexunit] Results :
 [flexunit] 
 [flexunit] Tests run: 22, Failures: 1, Errors: 1, Skipped: 1, Time elapsed: 0.364 sec
 [flexunit] 

BUILD FAILED
/Users/harbs/Documents/ApacheFlex/flex-tlf/build.xml:367: FlexUnit tests failed during the test run.

On Nov 19, 2014, at 11:03 AM, Harbs <ha...@gmail.com> wrote:

> I assume the problem is here:
> 
> [flexunit] Executing 'open' with arguments:
>  [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
>  [flexunit] 
>  [flexunit] The ' characters around the executable and arguments are
>  [flexunit] not part of the command.
> 
> I’m guessing you’ve been running the tests on Windows. It’s apparently not executing the swf correctly on Mac. The OS is trying to open the swf in Flash Professional.
> 
> On Nov 19, 2014, at 10:57 AM, Harbs <ha...@gmail.com> wrote:
> 
>> I just added flexdebug = true
>> 
>> It’s now opening VellumUnit in Flash CS5 and stalling in the same place.
>> 
>> Suggestions?
>> 
>> BTW, I recently started seeing this in the output when building tlf:
>> Please use CMSClassUnloadingEnabled in place of CMSPermGenSweepingEnabled in the future
>> 
>> I believe it started after you committed the tests.
>> 
>> On Nov 19, 2014, at 10:51 AM, Harbs <ha...@gmail.com> wrote:
>> 
>>> The Flash Player app? It doesn’t use the browser?
>>> 
>>> On Nov 19, 2014, at 10:42 AM, piotrz <pi...@gmail.com> wrote:
>>> 
>>>> Harbs,
>>>> 
>>>> Did Flash Player launch for you ? Probably unit tests couldn't launch flash
>>>> player. I don't have access to my dev environment now maybe should be setted
>>>> path to the FlashPlayer.exe somewhere...
>>>> 
>>>> I will check later today and let you know.
>>>> 
>>>> Piotr
>>>> 
>>>> 
>>>> 
>>>> -----
>>>> Apache Flex PMC
>>>> piotrzarzycki21@gmail.com
>>>> --
>>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42501.html
>>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>> 
>> 
> 


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I assume the problem is here:

[flexunit] Executing 'open' with arguments:
 [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
 [flexunit] 
 [flexunit] The ' characters around the executable and arguments are
 [flexunit] not part of the command.

I’m guessing you’ve been running the tests on Windows. It’s apparently not executing the swf correctly on Mac. The OS is trying to open the swf in Flash Professional.

On Nov 19, 2014, at 10:57 AM, Harbs <ha...@gmail.com> wrote:

> I just added flexdebug = true
> 
> It’s now opening VellumUnit in Flash CS5 and stalling in the same place.
> 
> Suggestions?
> 
> BTW, I recently started seeing this in the output when building tlf:
> Please use CMSClassUnloadingEnabled in place of CMSPermGenSweepingEnabled in the future
> 
> I believe it started after you committed the tests.
> 
> On Nov 19, 2014, at 10:51 AM, Harbs <ha...@gmail.com> wrote:
> 
>> The Flash Player app? It doesn’t use the browser?
>> 
>> On Nov 19, 2014, at 10:42 AM, piotrz <pi...@gmail.com> wrote:
>> 
>>> Harbs,
>>> 
>>> Did Flash Player launch for you ? Probably unit tests couldn't launch flash
>>> player. I don't have access to my dev environment now maybe should be setted
>>> path to the FlashPlayer.exe somewhere...
>>> 
>>> I will check later today and let you know.
>>> 
>>> Piotr
>>> 
>>> 
>>> 
>>> -----
>>> Apache Flex PMC
>>> piotrzarzycki21@gmail.com
>>> --
>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42501.html
>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>> 
> 


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I just added flexdebug = true

It’s now opening VellumUnit in Flash CS5 and stalling in the same place.

Suggestions?

BTW, I recently started seeing this in the output when building tlf:
Please use CMSClassUnloadingEnabled in place of CMSPermGenSweepingEnabled in the future

I believe it started after you committed the tests.

On Nov 19, 2014, at 10:51 AM, Harbs <ha...@gmail.com> wrote:

> The Flash Player app? It doesn’t use the browser?
> 
> On Nov 19, 2014, at 10:42 AM, piotrz <pi...@gmail.com> wrote:
> 
>> Harbs,
>> 
>> Did Flash Player launch for you ? Probably unit tests couldn't launch flash
>> player. I don't have access to my dev environment now maybe should be setted
>> path to the FlashPlayer.exe somewhere...
>> 
>> I will check later today and let you know.
>> 
>> Piotr
>> 
>> 
>> 
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42501.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
> 


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
The Flash Player app? It doesn’t use the browser?

On Nov 19, 2014, at 10:42 AM, piotrz <pi...@gmail.com> wrote:

> Harbs,
> 
> Did Flash Player launch for you ? Probably unit tests couldn't launch flash
> player. I don't have access to my dev environment now maybe should be setted
> path to the FlashPlayer.exe somewhere...
> 
> I will check later today and let you know.
> 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42501.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

Did Flash Player launch for you ? Probably unit tests couldn't launch flash
player. I don't have access to my dev environment now maybe should be setted
path to the FlashPlayer.exe somewhere...

I will check later today and let you know.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42501.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
Here’s the full output:
http://pastebin.com/RLCg8XGb

On Nov 19, 2014, at 10:25 AM, Harbs <ha...@gmail.com> wrote:

> After running ant all, these are the only files I see in that bin folder:
> 
> automation_core.swc
> automation_tests.swc
> Flow.swf
> swfobject.js
> VellumUnit.html
> VellumUnit.swf
> 
> On Nov 19, 2014, at 10:23 AM, Harbs <ha...@gmail.com> wrote:
> 
>> What’s this about?
>> 
>> flexunnit_tests:
>>  [flexunit] Validating task attributes ...
>>  [flexunit] Generating default values ...
>>  [flexunit] Using default working dir [/Users/harbs/Documents/ApacheFlex/flex-tlf]
>>  [flexunit] Using the following settings for the test run:
>>  [flexunit] 	FLEX_HOME: [/Users/harbs/Documents/ApacheFlex/flex-tlf/../flex-sdk]
>>  [flexunit] 	haltonfailure: [true]
>>  [flexunit] 	headless: [false]
>>  [flexunit] 	display: [99]
>>  [flexunit] 	localTrusted: [true]
>>  [flexunit] 	player: [flash]
>>  [flexunit] 	port: [1024]
>>  [flexunit] 	swf: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf]
>>  [flexunit] 	timeout: [60000ms]
>>  [flexunit] 	toDir: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin]
>>  [flexunit] Setting up server process ...
>>  [flexunit] Starting server ...
>>  [flexunit] Updated local trust file at [/Users/harbs/Library/Preferences/Macromedia/Flash Player/#Security/FlashPlayerTrust/flexUnit.cfg], added [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin].
>>  [flexunit] Executing 'open' with arguments:
>>  [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
>>  [flexunit] 
>>  [flexunit] The ' characters around the executable and arguments are
>>  [flexunit] not part of the command.
>>  [flexunit] 
>>  [flexunit] Opening server socket on port [1024].
>>  [flexunit] Waiting for client connection ...
>>  [flexunit] 
>>  [flexunit] Stopping server ...
>>  [flexunit] End of test data reached, sending acknowledgement to player ...
>>  [flexunit] Closing client connection ...
>>  [flexunit] Closing server on port [1024] …
>> 
>> On Nov 19, 2014, at 10:08 AM, piotrz <pi...@gmail.com> wrote:
>> 
>>> Hi Harbs,
>>> 
>>>> 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere
>>>> else? 
>>> 
>>> I mean flex-tlf build.properties
>>> 
>>>> 2) I’m not sure what you mean about FLEX_HOME. Is there something special
>>>> I need to do there besides what I’d do to make the SDK build? 
>>> 
>>> You have to create file env.properties in flex-tlf folder and set up there
>>> FLEX_HOME path to flex sdk
>>> 
>>>> 3) Is that ant on flex or tlf? What’s the exact command I need? “ant all”? 
>>> 
>>> This is ant in flex-tlf - build.xml file. 
>>> 
>>> Piotr
>>> 
>>> 
>>> 
>>> -----
>>> Apache Flex PMC
>>> piotrzarzycki21@gmail.com
>>> --
>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42496.html
>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>> 
> 


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
After running ant all, these are the only files I see in that bin folder:

automation_core.swc
automation_tests.swc
Flow.swf
swfobject.js
VellumUnit.html
VellumUnit.swf

On Nov 19, 2014, at 10:23 AM, Harbs <ha...@gmail.com> wrote:

> What’s this about?
> 
> flexunnit_tests:
>  [flexunit] Validating task attributes ...
>  [flexunit] Generating default values ...
>  [flexunit] Using default working dir [/Users/harbs/Documents/ApacheFlex/flex-tlf]
>  [flexunit] Using the following settings for the test run:
>  [flexunit] 	FLEX_HOME: [/Users/harbs/Documents/ApacheFlex/flex-tlf/../flex-sdk]
>  [flexunit] 	haltonfailure: [true]
>  [flexunit] 	headless: [false]
>  [flexunit] 	display: [99]
>  [flexunit] 	localTrusted: [true]
>  [flexunit] 	player: [flash]
>  [flexunit] 	port: [1024]
>  [flexunit] 	swf: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf]
>  [flexunit] 	timeout: [60000ms]
>  [flexunit] 	toDir: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin]
>  [flexunit] Setting up server process ...
>  [flexunit] Starting server ...
>  [flexunit] Updated local trust file at [/Users/harbs/Library/Preferences/Macromedia/Flash Player/#Security/FlashPlayerTrust/flexUnit.cfg], added [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin].
>  [flexunit] Executing 'open' with arguments:
>  [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
>  [flexunit] 
>  [flexunit] The ' characters around the executable and arguments are
>  [flexunit] not part of the command.
>  [flexunit] 
>  [flexunit] Opening server socket on port [1024].
>  [flexunit] Waiting for client connection ...
>  [flexunit] 
>  [flexunit] Stopping server ...
>  [flexunit] End of test data reached, sending acknowledgement to player ...
>  [flexunit] Closing client connection ...
>  [flexunit] Closing server on port [1024] …
> 
> On Nov 19, 2014, at 10:08 AM, piotrz <pi...@gmail.com> wrote:
> 
>> Hi Harbs,
>> 
>>> 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere
>>> else? 
>> 
>> I mean flex-tlf build.properties
>> 
>>> 2) I’m not sure what you mean about FLEX_HOME. Is there something special
>>> I need to do there besides what I’d do to make the SDK build? 
>> 
>> You have to create file env.properties in flex-tlf folder and set up there
>> FLEX_HOME path to flex sdk
>> 
>>> 3) Is that ant on flex or tlf? What’s the exact command I need? “ant all”? 
>> 
>> This is ant in flex-tlf - build.xml file. 
>> 
>> Piotr
>> 
>> 
>> 
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42496.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
> 


Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
What’s this about?

flexunnit_tests:
 [flexunit] Validating task attributes ...
 [flexunit] Generating default values ...
 [flexunit] Using default working dir [/Users/harbs/Documents/ApacheFlex/flex-tlf]
 [flexunit] Using the following settings for the test run:
 [flexunit] 	FLEX_HOME: [/Users/harbs/Documents/ApacheFlex/flex-tlf/../flex-sdk]
 [flexunit] 	haltonfailure: [true]
 [flexunit] 	headless: [false]
 [flexunit] 	display: [99]
 [flexunit] 	localTrusted: [true]
 [flexunit] 	player: [flash]
 [flexunit] 	port: [1024]
 [flexunit] 	swf: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf]
 [flexunit] 	timeout: [60000ms]
 [flexunit] 	toDir: [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin]
 [flexunit] Setting up server process ...
 [flexunit] Starting server ...
 [flexunit] Updated local trust file at [/Users/harbs/Library/Preferences/Macromedia/Flash Player/#Security/FlashPlayerTrust/flexUnit.cfg], added [/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin].
 [flexunit] Executing 'open' with arguments:
 [flexunit] '/Users/harbs/Documents/ApacheFlex/flex-tlf/bin/apps/automation_apps/bin/VellumUnit.swf'
 [flexunit] 
 [flexunit] The ' characters around the executable and arguments are
 [flexunit] not part of the command.
 [flexunit] 
 [flexunit] Opening server socket on port [1024].
 [flexunit] Waiting for client connection ...
 [flexunit] 
 [flexunit] Stopping server ...
 [flexunit] End of test data reached, sending acknowledgement to player ...
 [flexunit] Closing client connection ...
 [flexunit] Closing server on port [1024] …

On Nov 19, 2014, at 10:08 AM, piotrz <pi...@gmail.com> wrote:

> Hi Harbs,
> 
>> 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere
>> else? 
> 
> I mean flex-tlf build.properties
> 
>> 2) I’m not sure what you mean about FLEX_HOME. Is there something special
>> I need to do there besides what I’d do to make the SDK build? 
> 
> You have to create file env.properties in flex-tlf folder and set up there
> FLEX_HOME path to flex sdk
> 
>> 3) Is that ant on flex or tlf? What’s the exact command I need? “ant all”? 
> 
> This is ant in flex-tlf - build.xml file. 
> 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42496.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Hi Harbs,

> 1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere
> else? 

I mean flex-tlf build.properties

> 2) I’m not sure what you mean about FLEX_HOME. Is there something special
> I need to do there besides what I’d do to make the SDK build? 

You have to create file env.properties in flex-tlf folder and set up there
FLEX_HOME path to flex sdk

> 3) Is that ant on flex or tlf? What’s the exact command I need? “ant all”? 

This is ant in flex-tlf - build.xml file. 

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42496.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
It’s quite possible that I completely broke composition of floats. None of my test cases use floats.

I tried to stay away from changing anything that could affect floats, but I might have not been successful…

Some clarifications:

1) Do you mean the build.properties in flex-tlf? in flex-sdk? or somewhere else?
2) I’m not sure what you mean about FLEX_HOME. Is there something special I need to do there besides what I’d do to make the SDK build?
3) Is that ant on flex or tlf? What’s the exact command I need? “ant all”?

On Nov 19, 2014, at 12:18 AM, piotrz <pi...@gmail.com> wrote:

> Harbs,
> 
> I did quick look into the errors of failing tests. I don't know what could
> be the cause of this errors - you have to look into that on your own. :/
> 
> Class FloatTest - every test in this class is failing with the same error:
> 
> http://paste.ofcode.org/VJTfQaGaDgxeGnyRXg8jKu
> 
> Try to analize for example this test -> rightBigIndent - This is one of the
> failed method. 
> 
> To run only FloatTest and see what is happened you have to:
> 
> 1) In build.properties file set up
> 
> minimalTests = true 
> flexdebug = false - only if you want debuggable swf
> 
> 2) Setup in env.properties file FLEX_HOME path
> 
> 3) Run the tests using ant "all" target
> 
> Once the tests finished you will find xml report file in this location:
> 
> flex-tlf\bin\apps\automation_apps\bin\TEST-UnitTest.Tests.FloatTest.xml
> 
> Piotr
> 
> 
> 
> 
> 
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42486.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

I did quick look into the errors of failing tests. I don't know what could
be the cause of this errors - you have to look into that on your own. :/

Class FloatTest - every test in this class is failing with the same error:

http://paste.ofcode.org/VJTfQaGaDgxeGnyRXg8jKu

Try to analize for example this test -> rightBigIndent - This is one of the
failed method. 

To run only FloatTest and see what is happened you have to:

1) In build.properties file set up

minimalTests = true 
flexdebug = false - only if you want debuggable swf

2) Setup in env.properties file FLEX_HOME path

3) Run the tests using ant "all" target

Once the tests finished you will find xml report file in this location:

flex-tlf\bin\apps\automation_apps\bin\TEST-UnitTest.Tests.FloatTest.xml

Piotr








-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42486.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Hi Erik,

I did merge of my code (TLF unit tests - develope) into the Harbs's branch
(tables). I have managed to successful launch most of the tests on Harbs's
code however couple of them failed.  
I will try to find some time later this week and look into this. 

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42418.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by piotrz <pi...@gmail.com>.
Harbs,

Once you will be ready to start working on tests for tables we can schedule
another session on skype. I will guide you through code one of the existing
test class. :)

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p42419.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
I’ve tried to make as few changes to the APIs as possible. 99.9% of users will be able to switch transparently.

I am currently using the tables branch in the beta version of my software. That’s how I’m turning up these bugs. When I’m ready to push out to production, it should be in pretty good shape.

What that means practically is another question… ;-)

On Nov 17, 2014, at 1:02 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:

> What is you 'gut feeling' about the backwards compatibility of the table
> branch? In your project, I assume you use a lot of TLF code. I think I
> remember you have a very large text based application ... Will you be using
> your branch for your release software?
> 
> I'm asking so I can figure out if we want to include the branch in the next
> version of the SDK.
> 
> EdB
> 
> 
> 
> On Mon, Nov 17, 2014 at 11:56 AM, Harbs <ha...@gmail.com> wrote:
> 
>> Right now I’m working on a pretty serious bug in the table code related to
>> recomposition of TextFlowLines. (See the other thread.)
>> 
>> Once I have that behind me, I plan on trying to get some tests set up.
>> Piotr already merged the test code in with the table code, so that part is
>> done.
>> 
>> On Nov 17, 2014, at 12:53 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>> 
>>> Hi guys,
>>> 
>>> Can you update us on the status and "planning" (note the quotes, the
>> project doesn't require any schedule) of your contributions?
>>> 
>>> Thanks,
>>> 
>>> EdB
>>> 
>>> 
>>> 
>>> On Wed, Oct 29, 2014 at 12:13 PM, piotrz <pi...@gmail.com>
>> wrote:
>>> Thanks Erik! :)
>>> 
>>> Harbs I've sent you an invitation on skype.
>>> 
>>> Piotr
>>> 
>>> 
>>> 
>>> -----
>>> Apache Flex PMC
>>> piotrzarzycki21@gmail.com
>>> --
>>> View this message in context:
>> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p41913.html
>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>> 
>>> 
>>> 
>>> --
>>> Ix Multimedia Software
>>> 
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>> 
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>> 
>> 
> 
> 
> -- 
> Ix Multimedia Software
> 
> Jan Luykenstraat 27
> 3521 VB Utrecht
> 
> T. 06-51952295
> I. www.ixsoftware.nl


Re: Commit of table work

Posted by Erik de Bruin <er...@ixsoftware.nl>.
What is you 'gut feeling' about the backwards compatibility of the table
branch? In your project, I assume you use a lot of TLF code. I think I
remember you have a very large text based application ... Will you be using
your branch for your release software?

I'm asking so I can figure out if we want to include the branch in the next
version of the SDK.

EdB



On Mon, Nov 17, 2014 at 11:56 AM, Harbs <ha...@gmail.com> wrote:

> Right now I’m working on a pretty serious bug in the table code related to
> recomposition of TextFlowLines. (See the other thread.)
>
> Once I have that behind me, I plan on trying to get some tests set up.
> Piotr already merged the test code in with the table code, so that part is
> done.
>
> On Nov 17, 2014, at 12:53 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>
> > Hi guys,
> >
> > Can you update us on the status and "planning" (note the quotes, the
> project doesn't require any schedule) of your contributions?
> >
> > Thanks,
> >
> > EdB
> >
> >
> >
> > On Wed, Oct 29, 2014 at 12:13 PM, piotrz <pi...@gmail.com>
> wrote:
> > Thanks Erik! :)
> >
> > Harbs I've sent you an invitation on skype.
> >
> > Piotr
> >
> >
> >
> > -----
> > Apache Flex PMC
> > piotrzarzycki21@gmail.com
> > --
> > View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p41913.html
> > Sent from the Apache Flex Development mailing list archive at Nabble.com.
> >
> >
> >
> > --
> > Ix Multimedia Software
> >
> > Jan Luykenstraat 27
> > 3521 VB Utrecht
> >
> > T. 06-51952295
> > I. www.ixsoftware.nl
>
>


-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Commit of table work

Posted by Harbs <ha...@gmail.com>.
Right now I’m working on a pretty serious bug in the table code related to recomposition of TextFlowLines. (See the other thread.)

Once I have that behind me, I plan on trying to get some tests set up. Piotr already merged the test code in with the table code, so that part is done.

On Nov 17, 2014, at 12:53 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:

> Hi guys, 
> 
> Can you update us on the status and "planning" (note the quotes, the project doesn't require any schedule) of your contributions?
> 
> Thanks,
> 
> EdB
> 
> 
> 
> On Wed, Oct 29, 2014 at 12:13 PM, piotrz <pi...@gmail.com> wrote:
> Thanks Erik! :)
> 
> Harbs I've sent you an invitation on skype.
> 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Commit-of-table-work-tp41095p41913.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
> 
> 
> 
> -- 
> Ix Multimedia Software
> 
> Jan Luykenstraat 27
> 3521 VB Utrecht
> 
> T. 06-51952295
> I. www.ixsoftware.nl