[GitHub] jihoonson commented on a change in pull request #7063: ParallelIndexSubTask: support ingestSegment in delegating factories

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7063: ParallelIndexSubTask: support ingestSegment in delegating factories
URL: https://github.com/apache/incubator-druid/pull/7063#discussion_r256658650
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/FirehoseFactory.java
 ##########
 @@ -77,4 +77,14 @@ default boolean isSplittable()
   {
     return false;
   }
+
+  /**
+   * Some FirehoseFactory implementations require additional context from the task that uses them.
+   * For example, IngestSegmentFirehoseFactory needs a TaskToolbox from the indexing-service task.
+   * This method is also implemented by implementations such as CombiningFirehoseFactory which wrap
+   * other implementations.
+   */
+  default void setContext(String key, Object value)
 
 Review comment:
   Do you have any plan to add other stuffs in addition to `taskToolBox`? If not, it looks too general to me.
   
   Also, what do you think about adding a new parameter for `taskToolBox` to `connect()`? Even though It's currently used only in `IngestSegmentFirehoseFactory.connect()`, the delegating firehoseFactories should pass them, so I think it makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org