[jira] Commented: (WICKET-306) XML License Header Tests fail with Unicode BOM

["Timo Rantalaiho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604655#action_12604655 ] 

Timo Rantalaiho commented on WICKET-306:
----------------------------------------

What is the impact of this bug? Am I missing something, or is it just that if you add a UTF-8 XML file with a BOM in the project, the build will fail?

If that is the case, maybe it is an acceptable workaround to fix such files by hand with the way that Jean-Baptiste presents, until we move to Java 6. The build server should let us know if that happens.

> XML License Header Tests fail with Unicode BOM
> ----------------------------------------------
>
>                 Key: WICKET-306
>                 URL: https://issues.apache.org/jira/browse/WICKET-306
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>             Fix For: 1.4-M3
>
>
> License header tests use FileReader, which is subject to a JDK bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4508058
> Namely, if the XML file is encoded using UTF-8 *and* has a BOM (this is optional), license check fails.
> We might integrate Unicode Reader from http://koti.mbnet.fi/akini/java/unicodereader/ provided that the license is ASL compatible.
> A workaround is to remove the optional Unicode BOM.  I do that in Vim by using "set nobomb" and writing the file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.