[GitHub] [cordova-docs] raphinesse edited a comment on issue #981: buildAndDeploy.sh does not fail Travis CI build when something goes wrong

[GitBox <gi...@apache.org>]

raphinesse edited a comment on issue #981: buildAndDeploy.sh does not fail Travis CI build when something goes wrong
URL: https://github.com/apache/cordova-docs/issues/981#issuecomment-490495920
 
 
   > The script is called in travis.yml:
   > 
   > https://github.com/apache/cordova-docs/blob/a874adcee425dbadb54a44a9dbfa0fbee2796feb/.travis.yml#L11-L12
   > 
   > Docs on `travis_wait`: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
   
   The `travis_wait` is fine if that script really can run for up to 30 minutes (can it?). The Problem is `sleep infinity & ./buildAndDeploy.sh ` AFAIK, this will run `sleep infinity` and `./buildAndDeploy.sh` in subshells in the background, and return `0` immediately. Probably `travis_wait` waits for all child processes to terminate, otherwise the build would not even wait for the completion of `./buildAndDeploy.sh`.
   
   Since the very suspicious `sleep infinity &` is introduced in https://github.com/apache/cordova-docs/commit/4fd14a7d509dd0ad5889bf4dfb63b07b436d900c without any explanation, I would just drop it and see what happens (According to that commit, `npm run build` is the long-running part).
   
   So just change that line to `travis_wait 30 ./buildAndDeploy.sh` for a quick fix. Later on, one could split that script up and actually use the build and deploy stages of Travis :sweat_smile: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org