You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 22:50:12 UTC

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1473: [HUDI-568] Improve unit test coverage

n3nash commented on a change in pull request #1473: [HUDI-568] Improve unit test coverage
URL: https://github.com/apache/incubator-hudi/pull/1473#discussion_r401955277
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java
 ##########
 @@ -75,9 +75,6 @@ public RocksDBDAO(String basePath, String rocksDBBasePath) {
    * Create RocksDB if not initialized.
    */
   private RocksDB getRocksDB() {
-    if (null == rocksDB) {
 
 Review comment:
   What if getRocksDB is called repetitively ? It should not init() every time, do we plan to add a different check in init to allow for better code coverage ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services