You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/10 09:24:25 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

shwstppr opened a new pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429


   ### Description
   
   NIC Adapter type option is missing in Register/Upload template form.
   This PR fixes the behaviour
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   Before:
   ![Screenshot from 2021-09-10 14-52-41](https://user-images.githubusercontent.com/153340/132831984-e6cf259d-f07c-401e-8e3f-fb4c89f291e9.png)
   
   
   After:
   ![Screenshot from 2021-09-10 14-49-32](https://user-images.githubusercontent.com/153340/132832022-005f82e0-7a76-4ad6-966f-1482e4b918d8.png)
   
   
   ### How Has This Been Tested?
   ![Screenshot from 2021-09-10 14-39-06](https://user-images.githubusercontent.com/153340/132832048-f6583a71-f63e-4f91-ae0d-b5acc3553048.png)
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916843978


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-626)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916841814


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916841590


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916840679


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916832946


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916833950


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916843359


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-625)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916840679


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429#issuecomment-916835943


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-624)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5429: ui: show nicAdapter selection for VMware non-readfromova template

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5429:
URL: https://github.com/apache/cloudstack/pull/5429


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org