You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andrewpalumbo <gi...@git.apache.org> on 2016/04/14 20:31:38 UTC
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
GitHub user andrewpalumbo opened a pull request:
https://github.com/apache/flink/pull/1891
FLINK-3762: StackOverflowError due to disabled Kryo Reference tracking
cription
As discussed on the dev list,
In `KryoSerializer.java`
Kryo Reference tracking is disabled by default:
```java
kryo.setReferences(false);
```
This can causes StackOverflowError Exceptions when serializing many objects that may contain recursive objects:
```
java.lang.StackOverflowError
at com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:48)
at com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:495)
at com.esotericsoftware.kryo.Kryo.writeObject(Kryo.java:523)
at com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:61)
at com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:495)
at com.esotericsoftware.kryo.Kryo.writeObject(Kryo.java:523)
at com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:61)
at com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:495)
at com.esotericsoftware.kryo.Kryo.writeObject(Kryo.java:523)
at com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:61)
at com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:495)
```
By enabling reference tracking, we can fix this problem.
[1]https://gist.github.com/andrewpalumbo/40c7422a5187a24cd03d7d81feb2a419
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewpalumbo/flink FLINK-3762
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1891.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1891
----
commit 72f5bad9ebb1e657336e2c3e8ea8eb9ee283f693
Author: Andrew Palumbo <ap...@apache.org>
Date: 2016-04-14T18:25:46Z
FLINK-3762: enable kryo refrence tracking
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1891#issuecomment-210402401
Changes look good to me. +1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by andrewpalumbo <gi...@git.apache.org>.
Github user andrewpalumbo commented on the pull request:
https://github.com/apache/flink/pull/1891#issuecomment-210576438
Thank you guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1891#issuecomment-210402429
Thanks for your contribution @andrewpalumbo :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1891
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1891#issuecomment-210403044
Thanks, will merge this PR to master and release-1.0 branches
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3762: StackOverflowError due to disabled...
Posted by andrewpalumbo <gi...@git.apache.org>.
Github user andrewpalumbo commented on the pull request:
https://github.com/apache/flink/pull/1891#issuecomment-210208137
Flipped the `validateReferenceMappingDisabled()` test in `KryoGenericSerializerTest` to assert that Kryo referencing is enabled.
```java
public void validateReferenceMappingEnabled() {
KryoSerializer<String> serializer = new KryoSerializer<>(String.class, new ExecutionConfig());
Kryo kryo = serializer.getKryo();
assertTrue(kryo.getReferences());
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---