[GitHub] [arrow-rs] JasonLi-cn commented on a diff in pull request #2314: fix: IPC writer should truncate string array with all empty string

[GitBox <gi...@apache.org>]

JasonLi-cn commented on code in PR #2314:
URL: https://github.com/apache/arrow-rs/pull/2314#discussion_r937331835


##########
arrow/src/ipc/writer.rs:
##########
@@ -1005,13 +1015,16 @@ fn write_array_data(
         data_type,
         DataType::Binary | DataType::LargeBinary | DataType::Utf8 | DataType::LargeUtf8
     ) {
-        let total_bytes = get_binary_buffer_len(array_data);
-        let value_buffer = &array_data.buffers()[1];
+        let offset_buffer = &array_data.buffers()[0];
+        let value_offset_byte_width = get_value_offset_byte_width(data_type);
+        let min_length = array_data.len() * value_offset_byte_width;

Review Comment:
   yes, I modify it, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org