You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/10 01:23:38 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

HyukjinKwon commented on a change in pull request #33627:
URL: https://github.com/apache/spark/pull/33627#discussion_r705827236



##########
File path: core/src/main/resources/error/README.md
##########
@@ -98,6 +98,7 @@ Spark only uses the standard-defined classes and subclasses, and does not use im
 
 The following SQLSTATEs are from ISO/IEC CD 9075-2.
 
+[//]: # (SQLSTATE table start)

Review comment:
       Should we maybe use HTML comments like:
   
   ```
   <!-- SQLSTATE table start -->
   ...
   <!-- SQLSTATE table stop -->
   ```
   
   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org