You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Clint Morgan (JIRA)" <ji...@apache.org> on 2009/06/25 00:03:07 UTC
[jira] Created: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Translate ColumnValueFilter and RowFilterSet to the new Filter interface
------------------------------------------------------------------------
Key: HBASE-1582
URL: https://issues.apache.org/jira/browse/HBASE-1582
Project: Hadoop HBase
Issue Type: New Feature
Components: filters
Affects Versions: 0.20.0
Reporter: Clint Morgan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-1582:
--------------------------------
Attachment: 1582.patch
These work so far for me. Calling it ColValueFilter because ColumnValueFilter is still around.
Should we delete all traces of the old interfaces if we won't support them? The javadoc on ColumnValueFilter says its a noop in 0.20.
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Attachments: 1582.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725468#action_12725468 ]
stack commented on HBASE-1582:
------------------------------
Committed part 1. Adds new Clint filters and some basic tests that need fleshing out. Also does a bunch of renaming in filter dirs. Uses consistent pattern where we drop 'Row' from old name.
Renamed RowPrefixFilter as PrefixFilter
Added new Set of filters as FilterSet.
Renamed RowWhileMatchFilter as WhileMatchFilter
RowInclusiveStopFilter as InclusiveRowFilter
RowPageFilter as PageFilter
ColValueFilter as ValueFilter
Renamed tests to align.
Part 2 will be tightening up the filter tests.
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch, filters.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1582.
--------------------------
Resolution: Fixed
Hadoop Flags: [Incompatible change, Reviewed]
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch, filters.patch, filters2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1582:
-------------------------
Attachment: filters.patch
Adding tests for Clints new filters. Renaming colvaluefilter as ValueFilter. Doing a bunch of other column namings because looks like new filters can just drop 'Row' from name and then they'll be easy to recognize. This patch is not finished.
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch, filters.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-1582:
--------------------------------
Fix Version/s: 0.20.0
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724324#action_12724324 ]
stack commented on HBASE-1582:
------------------------------
The class comment on FilterSet seems wrong (and elsewhere in javadoc). Says Implementation of RowFilterInterface. Should that be Filter?
Was going to suggest that we instead have a FilterList rather than FilterSet so could ordain order in which filters run but that is probably asking for trouble. Filters should be idempotent.
License should be 2009, not 2008.
Any chance of basic tests so we have some chance of knowing when we've broken these things?
On removing old filters, some of the old still work. How about we remove those that for sure don't. For example, call your new column filter by the old name since the old is broken (Replace old with the new)?
Otherwise, patch looks great.
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1582) Translate ColumnValueFilter and
RowFilterSet to the new Filter interface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1582:
-------------------------
Attachment: filters2.patch
This patch adds tests for new FilterSet and ValueFilter (ValueFilter is new name for ColumnValueFilter). Also renames most filters to drop 'Row' from their name to match convention established by our naming of the filter interface 'Filter' (Used to be RowFilterInterface) with presumption that this filter system is all row based. Removed dead tests that had Disabled prefix. Added new InclusiveFilter test.
> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
> Key: HBASE-1582
> URL: https://issues.apache.org/jira/browse/HBASE-1582
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1582.patch, filters.patch, filters2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.