You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Xiaoyu Yao (Jira)" <ji...@apache.org> on 2021/03/12 02:50:00 UTC
[jira] [Commented] (HADOOP-17482) Remove Commons Logger from
FileSystem Class
[ https://issues.apache.org/jira/browse/HADOOP-17482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300000#comment-17300000 ]
Xiaoyu Yao commented on HADOOP-17482:
-------------------------------------
Agree with [~stevel@apache.org] mentioned above. The Jira is open but PR has been merged.
The merged change breaks the Hadoop CI/Jenkins as now the ambiguity issue between two slf4j Logger instances to the same FileSystem.class failed the build.
Previously log instances seem hacky with as one from common logger and one from slf4j.
{code:java}
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2762/src/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java:[1424,25] error: reference to LOG is ambiguous
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2762/src/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithKMS.java:[102,25] error: reference to LOG is ambiguous
[INFO] 2 errors
{code}
> Remove Commons Logger from FileSystem Class
> -------------------------------------------
>
> Key: HADOOP-17482
> URL: https://issues.apache.org/jira/browse/HADOOP-17482
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Remove reference to Commons Logger in FileSystem, it already has SLF4J, so it's a bit weird to be mixing and matching and interweaving loggers in this way. Also, my hope is to eventually migrate everything to SLF4J to simplify things for downstream consumers of the common library.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org