You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 03:48:43 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4248: mtd: Add MTDIOC_FIRSTBLOCK for retrieving an MTD partition first block
xiaoxiang781216 commented on a change in pull request #4248:
URL: https://github.com/apache/incubator-nuttx/pull/4248#discussion_r678800451
##########
File path: include/nuttx/mtd/mtd.h
##########
@@ -74,6 +74,9 @@
#define MTDIOC_ERASESTATE _MTDIOC(0x000a) /* IN: Pointer to uint8_t
* OUT: Byte value that represents the
* erased state of the MTD cell */
+#define MTDIOC_FIRSTBLOCK _MTDIOC(0x000b) /* IN: Pointer to off_t
Review comment:
how about block device?
##########
File path: include/nuttx/mtd/mtd.h
##########
@@ -74,6 +74,9 @@
#define MTDIOC_ERASESTATE _MTDIOC(0x000a) /* IN: Pointer to uint8_t
* OUT: Byte value that represents the
* erased state of the MTD cell */
+#define MTDIOC_FIRSTBLOCK _MTDIOC(0x000b) /* IN: Pointer to off_t
Review comment:
How about add the new field to mtd_geometry_s or geometry? the start of block is also a key metric for block/mtd geometry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org