You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/21 07:03:04 UTC

[GitHub] [incubator-mxnet] zheng-da commented on a change in pull request #15016: [MXNET-1406] [BUG] Fix DLManagedTensor deleter

zheng-da commented on a change in pull request #15016: [MXNET-1406] [BUG] Fix DLManagedTensor deleter
URL: https://github.com/apache/incubator-mxnet/pull/15016#discussion_r285874587
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -818,10 +818,12 @@ MXNET_DLL int MXNDArrayToDLPack(NDArrayHandle handle,
 * The memory is retained until the NDArray went out of scope.
 *
 * \param dlpack the pointer of the input DLManagedTensor
+* \param transient_handle whether the handle will be destructed before calling the deleter
 
 Review comment:
   before calling?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services