[jira] [Commented] (OFBIZ-5430) "Please Select Your Shipping Method" error sometimes occurs when updating order items

["Christian Carlow (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866710#comment-13866710 ] 

Christian Carlow commented on OFBIZ-5430:
-----------------------------------------

I just encountered this error again on the Demo Site upon trying to update the price of the order item for orderId DEMO10090.  I'm pretty sure the error is due to setUserLogin() being called before the ship groups get created for the cart in loadCartFromOrder().  setUserLogin() expects the ShipGroups to have already been created.  To resolve the issue, orderItemShipGroup handling statements performed later in the function should be changed to be performed before setUserLogin() is called.

I'm almost done with OFBIZ-5440 which required this issue to be fixed so it will be included for the patch for that issue.

> "Please Select Your Shipping Method" error sometimes occurs when updating order items
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5430
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5430
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Christian Carlow
>
> Sometimes when an order item is appended or existing order items are updated, a "Please Select Your Shipment Method" error occurs.  I'm not exactly sure what causes this but it seems to be intermittent because sometimes I'm able to perform both of the operations without the error occur.  
> The problem seems to be that an extra empty ship group is added to the cart and takes the index position of first ship group.  Because the empty ship group contains no shipmentMethodTypeId or carrierPartyId the error occurs.
> Logic needs to exist to prevent the empty ship group that causes this issue from ever being added to the cart.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)