[GitHub] [spark] itholic commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1285322684


##########
python/pyspark/pandas/tests/frame/test_reindexing.py:
##########
@@ -854,7 +879,8 @@ def test_sample(self):
 
 
 class FrameReidexingTests(FrameReindexingMixin, ComparisonTestBase, SQLTestUtils):
-    pass
+    def test_between_time(self):
+        super().test_between_time()

Review Comment:
   We don't need to add a test here, since `FrameReidexingTests` already inherits `FrameReindexingMixin`.



##########
python/pyspark/pandas/series.py:
##########
@@ -6740,15 +6737,10 @@ def between_time(
             Initial time as a time filter limit.
         end_time : datetime.time or str
             End time as a time filter limit.
-        include_start : bool, default True
-            Whether the start time needs to be included in the result.
+        inclusive : {"both", "neither", "left", "right"}, default "both"
+            Include boundaries; whether to set each bound as closed or open.
 
-            .. deprecated:: 3.4.0
-
-        include_end : bool, default True
-            Whether the end time needs to be included in the result.
-
-            .. deprecated:: 3.4.0
+            .. versionadded:: 3.5.0

Review Comment:
   Should be 4.0.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org