You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/18 23:13:27 UTC
[GitHub] [samza] Zhangyx39 opened a new pull request #1320: SAMZA-2490:
AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
Zhangyx39 opened a new pull request #1320: SAMZA-2490: AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
URL: https://github.com/apache/samza/pull/1320
Symptom: In beam samza runner, Op#close is not invoked during shutdown, which is not expected.
Cause: AsyncFlatmapOperatorImpl#handleClose() doesn't call transformFn.close(). Therefore the underlying transform function will never be closed.
Changes: Just invoke transformFn.close inside handleClose method should be enough.
Tests: Tested with a samza beam job. After the change, Op#close is able to function properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] xinyuiscool merged pull request #1320: SAMZA-2490:
AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
Posted by GitBox <gi...@apache.org>.
xinyuiscool merged pull request #1320: SAMZA-2490: AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
URL: https://github.com/apache/samza/pull/1320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] xinyuiscool commented on issue #1320: SAMZA-2490:
AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
Posted by GitBox <gi...@apache.org>.
xinyuiscool commented on issue #1320: SAMZA-2490: AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
URL: https://github.com/apache/samza/pull/1320#issuecomment-600908769
Thanks for finding this bug. Can we add a unit test to prevent this happening again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services