You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/23 11:00:56 UTC
[GitHub] [hadoop-ozone] nandakumar131 opened a new pull request #861: HDDS-3483. Handle unhealthy replica state of an open container.
nandakumar131 opened a new pull request #861:
URL: https://github.com/apache/hadoop-ozone/pull/861
HDDS-3483. Handle unhealthy replica state of an open container.
It was assumed that when a container is in OPEN state SCM doesn't have to take any action on it and the Ratis pipeline in datanode should handle the consistency of that container.
But, there are cases where a replica of a container which is in OPEN state can be marked as UNHEALTHY in datanode. This should be handled in SCM.
## How was this patch tested?
Added unit test to verify the new functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek edited a comment on issue #861: HDDS-3483. Handle unhealthy replica state of an open container.
Posted by GitBox <gi...@apache.org>.
elek edited a comment on issue #861:
URL: https://github.com/apache/hadoop-ozone/pull/861#issuecomment-618497085
Thanks to open this issue @nandakumar131, one minor comment:
```
+ // Wait for EventQueue to call the event handler
+ Thread.sleep(100L);
+ Mockito.verify(closeContainerHandler, Mockito.times(1))
+ .onMessage(id, eventQueue);
```
FYI: Instead of using `Thread.sleep` we have a better api: `eventQueue.processAll(5000);`
(Sorry, I was not fast enough to comment it during the 1-2 hours to window while it was open. Keeping it open more time can give everybody a chance to check it (especially as US is waking up just now))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek edited a comment on issue #861: HDDS-3483. Handle unhealthy replica state of an open container.
Posted by GitBox <gi...@apache.org>.
elek edited a comment on issue #861:
URL: https://github.com/apache/hadoop-ozone/pull/861#issuecomment-618497085
Thanks to open this issue @nandakumar131, one minor comment:
```
+ // Wait for EventQueue to call the event handler
+ Thread.sleep(100L);
+ Mockito.verify(closeContainerHandler, Mockito.times(1))
+ .onMessage(id, eventQueue);
```
FYI: Instead of using `Thread.sleep` we have a better api: `eventQueue.processAll(5000);`
(Sorry, I was not fast enough to comment it during the 1-2 hours window while it was open. Keeping it open more time can give everybody a chance to check it (especially as US is waking up just now))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #861: HDDS-3483. Handle unhealthy replica state of an open container.
Posted by GitBox <gi...@apache.org>.
elek commented on issue #861:
URL: https://github.com/apache/hadoop-ozone/pull/861#issuecomment-618497085
Thanks to open this issue @nandakumar131, one minor comment:
{code}
+ // Wait for EventQueue to call the event handler
+ Thread.sleep(100L);
+ Mockito.verify(closeContainerHandler, Mockito.times(1))
+ .onMessage(id, eventQueue);
{code}
FYI: Instead of using `Thread.sleep` we have a better api: `eventQueue.processAll(5000);`
(Sorry, I was not fast enough to comment it during the 1-2 hours to window while it was open. Keeping it open more time can give everybody a chance to check it (especially as US is waking up just now))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] nandakumar131 commented on issue #861: HDDS-3483. Handle unhealthy replica state of an open container.
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on issue #861:
URL: https://github.com/apache/hadoop-ozone/pull/861#issuecomment-618519077
Thanks for the review @elek.
Good to know that we have the API exposed in `EventQueue`. I'm also not a fan of `Thread#sleep` in test cases.
We should even refactor other tests in the class to use `EventQueue#processAll`. Created HDDS-3484 for the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org