[jira] [Commented] (MINDEXER-97) Add OSGi 5.0 MANIFEST headers to OsgiArtifactIndexCreator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINDEXER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952313#comment-15952313 ] 

ASF GitHub Bot commented on MINDEXER-97:
----------------------------------------

Github user sesuncedu commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
  
    @cstamas Squashbasing gives the cleanest trees. Just make sure to give yourself credit for the commits of yours that were cherry-picked. 
    
    index-reader should be identical for both branches. There's only a single package, and  I bumped the OSGI package version to 5.2.0, since the additional public static fields are a minor API change over 5.1.2 .  Since nexus is using karaf features / pax-aether-url , this isn't as necessary or helpful or as it might be, but it does mean that the feature assembly can safely refer to the 6.0 index-reader snapshot, since the osgi package version is explicitly backwards compatible. 
    
    I actually ended up doing a third version of the changes as kludges on top of the nexus-public maven repository plugin. The main annoyance with index-reader was having to subclass  Expander / Compactor to handle the additional fields,  where a default mapping would have been simple.  
    
      Since I needed to build some mapping tables anyway to stash the relevant manifest headers in an asset child map where they wouldn't get in the way, doing Expander/Compactor wasn't that much of an extra hassle, but if the index-reader is used to build federations, it is useful to be able to have unrecognized fields be passed through as strings (e.g. if jigsaw is released, exchanging headers from module-info.class (and now possibly the manifest?) will be useful for federated systems).


> Add OSGi 5.0 MANIFEST headers to OsgiArtifactIndexCreator
> ---------------------------------------------------------
>
>                 Key: MINDEXER-97
>                 URL: https://issues.apache.org/jira/browse/MINDEXER-97
>             Project: Maven Indexer
>          Issue Type: Improvement
>            Reporter: Balazs Zsoldos
>
> It would be extremely useful if the following MANIFEST headers were added to the index:
>  - Require-Capability
>  - Provide-Capability
>  - DynamicImport-Package
> Especially the first two would be necessary to be able to build up a database that helps finding dependencies for unsatisfied bundles.       



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)