[GitHub] [guacamole-client] JordiRoman commented on a change in pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script

[GitBox <gi...@apache.org>]

JordiRoman commented on a change in pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#discussion_r451335037



##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
     ln -s /opt/guacamole/duo/guacamole-auth-*.jar   "$GUACAMOLE_EXT"
 }
 
+##
+## Adds properties to guacamole.properties witch configure the Cas
+## authentication service.
+##
+associate_cas() {
+    # Verify required parameters are present
+    if [ -z "$CAS_AUTHORIZATION_ENDPOINT" ] || \
+       [ -z "$CAS_REDIRECT_URI" ]
+    then
+        cat <<END
+FATAL: Missing required environment variables
+-----------------------------------------------------------------------------------
+If using the Cas authentication extension, you must provide each of the

Review comment:
       yes, it's a typo error.
   
   Can or should I add a new commit to the branch?
   
   What should the commit description be [GUACAMOLE-1082: Add guacamole-auth-cas to docker Script - Cas 2 CAS typo ]?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org