You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/12 05:05:24 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #18013: [improve][common] Add thread name for RateLimiter.
Technoboy- opened a new pull request, #18013:
URL: https://github.com/apache/pulsar/pull/18013
### Contribution Checklist
### Motivation
Add thread name for RateLimiter
### Documentation
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
### Matching PR in forked repository
PR in forked repository: https://github.com/Technoboy-/pulsar/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18013: [improve][common] Add thread name for RateLimiter.
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18013:
URL: https://github.com/apache/pulsar/pull/18013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #18013: [improve][common] Add thread name for RateLimiter.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #18013:
URL: https://github.com/apache/pulsar/pull/18013#discussion_r993583630
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java:
##########
@@ -80,7 +81,8 @@ public class RateLimiter implements AutoCloseable{
this.executorService = scheduledExecutorService;
this.externalExecutor = true;
} else {
- final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1);
+ final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1,
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18013: [improve][common] Add thread name for RateLimiter.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18013:
URL: https://github.com/apache/pulsar/pull/18013#issuecomment-1275886025
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18013?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@7e420c6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18013 +/- ##
=========================================
Coverage ? 27.37%
Complexity ? 3568
=========================================
Files ? 393
Lines ? 43418
Branches ? 4462
=========================================
Hits ? 11884
Misses ? 29684
Partials ? 1850
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `27.37% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #18013: [improve][common] Add thread name for RateLimiter.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #18013:
URL: https://github.com/apache/pulsar/pull/18013#discussion_r993536533
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java:
##########
@@ -80,7 +81,8 @@ public class RateLimiter implements AutoCloseable{
this.executorService = scheduledExecutorService;
this.externalExecutor = true;
} else {
- final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1);
+ final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1,
Review Comment:
pulsar-rate-limiter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org