[GitHub] [arrow-rs] ahmedriza commented on a diff in pull request #1719: Change parquet `ArrowFileWriter` to use standard `std:io::Write` rather custom `ParquetWriter` trait (#1717) (#1163)

[GitBox <gi...@apache.org>]

ahmedriza commented on code in PR #1719:
URL: https://github.com/apache/arrow-rs/pull/1719#discussion_r879561306


##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -188,7 +190,7 @@ impl<W: 'static + ParquetWriter> ArrowWriter<W> {
             write_leaves(row_group_writer.as_mut(), &arrays, &mut levels)?;
         }
 
-        self.writer.close_row_group(row_group_writer)?;
+        row_group_writer.close().unwrap();

Review Comment:
   Since this returns a `Result` anyway, is there a particular reason to call `unwrap` instead of using `?`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org