You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/05/26 13:55:47 UTC
[jira] [Created] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Make Shell's -d and debug cmd behave the same
---------------------------------------------
Key: HBASE-3925
URL: https://issues.apache.org/jira/browse/HBASE-3925
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.90.3
Reporter: Lars George
Priority: Trivial
Fix For: 0.90.4, 0.92.0
The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
{noformat}
# Debugging method
def debug
if @shell.debug
@shell.debug = false
conf.back_trace_limit = 0
else
@shell.debug = true
conf.back_trace_limit = 100
end
debug?
end
{noformat}
could be something like
{noformat}
# Debugging method
def debug
if @shell.debug
@shell.debug = false
conf.back_trace_limit = 0
log_level = org.apache.log4j.Level::ERROR
else
@shell.debug = true
conf.back_trace_limit = 100
log_level = org.apache.log4j.Level::DEBUG
end
org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
debug?
end
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482944#comment-13482944 ]
Ted Yu commented on HBASE-3925:
-------------------------------
@Lars George:
Do you want to take a look at the patch ?
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482938#comment-13482938 ]
Hadoop QA commented on HBASE-3925:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550584/HBASE-3925-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3132//console
This message is automatically generated.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485610#comment-13485610 ]
Hudson commented on HBASE-3925:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #242 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/242/])
HBASE-3925 Make Shell's -d and debug cmd behave the same (Revision 1402923)
Result = FAILURE
stack :
Files :
* /hbase/trunk/bin/hirb.rb
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-3925) Make Shell's -d and
debug cmd behave the same
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039685#comment-13039685 ]
Lars George edited comment on HBASE-3925 at 5/26/11 12:42 PM:
--------------------------------------------------------------
Also fix the initial flag when using the -d option. Currently we have this:
{noformat}
$ bin/hbase shell -d
Setting DEBUG log level...
HBase Shell; enter 'help<RETURN>' for list of supported commands.
Type "exit<RETURN>" to leave the HBase Shell
Version 0.91.0-SNAPSHOT, r1127782, Thu May 26 10:28:47 CEST 2011
hbase(main):001:0> debug?
Debug mode is OFF
{noformat}
No biggie, but inconsistent nevertheless.
was (Author: larsgeorge):
Also fix the initial flag when using the -d option. Currently we have this:
{noformat}
$ bin/hbase shell -d
debuSetting DEBUG log level...
gHBase Shell; enter 'help<RETURN>' for list of supported commands.
Type "exit<RETURN>" to leave the HBase Shell
Version 0.91.0-SNAPSHOT, r1127782, Thu May 26 10:28:47 CEST 2011
hbase(main):001:0> debug?
Debug mode is OFF
{noformat}
No biggie, but inconsistent nevertheless.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3
> Reporter: Lars George
> Priority: Trivial
> Fix For: 0.90.4, 0.92.0
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3925:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied to trunk. Thanks for the patch Liang.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482620#comment-13482620 ]
Ted Yu commented on HBASE-3925:
-------------------------------
Change looks good.
Please generate the patch from root directory of workspace.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485552#comment-13485552 ]
Hudson commented on HBASE-3925:
-------------------------------
Integrated in HBase-TRUNK #3492 (See [https://builds.apache.org/job/HBase-TRUNK/3492/])
HBASE-3925 Make Shell's -d and debug cmd behave the same (Revision 1402923)
Result = FAILURE
stack :
Files :
* /hbase/trunk/bin/hirb.rb
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482014#comment-13482014 ]
liang xie commented on HBASE-3925:
----------------------------------
Could anyone help to review it? thanks in advance
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liang xie updated HBASE-3925:
-----------------------------
Fix Version/s: (was: 0.96.0)
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.96.0, 0.98.0, 0.94.3
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443741#comment-13443741 ]
Hadoop QA commented on HBASE-3925:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542735/HBASE-3925.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2723//console
This message is automatically generated.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.96.0, 0.98.0, 0.94.3
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liang xie updated HBASE-3925:
-----------------------------
Attachment: HBASE-3925-v2.txt
Attached patch addressed Ted's comment
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039685#comment-13039685 ]
Lars George commented on HBASE-3925:
------------------------------------
Also fix the initial flag when using the -d option. Currently we have this:
{noformat}
$ bin/hbase shell -d
debuSetting DEBUG log level...
gHBase Shell; enter 'help<RETURN>' for list of supported commands.
Type "exit<RETURN>" to leave the HBase Shell
Version 0.91.0-SNAPSHOT, r1127782, Thu May 26 10:28:47 CEST 2011
hbase(main):001:0> debug?
Debug mode is OFF
{noformat}
No biggie, but inconsistent nevertheless.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3
> Reporter: Lars George
> Priority: Trivial
> Fix For: 0.90.4, 0.92.0
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liang xie updated HBASE-3925:
-----------------------------
Affects Version/s: 0.94.3
0.98.0
0.96.0
0.92.2
0.90.7
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.96.0, 0.98.0, 0.94.3
> Reporter: Lars George
> Priority: Trivial
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liang xie updated HBASE-3925:
-----------------------------
Fix Version/s: 0.96.0
Assignee: liang xie
Labels: patch (was: )
Status: Patch Available (was: Open)
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.96.0, 0.98.0, 0.94.3
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485267#comment-13485267 ]
stack commented on HBASE-3925:
------------------------------
[~xieliang007] Mind attaching console output that demonstrates this patch does what it claims? Patch looks good.
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485375#comment-13485375 ]
liang xie commented on HBASE-3925:
----------------------------------
[root@ha1 bin]# ./hbase shell -d
Setting DEBUG log level
......
hbase(main):001:0> debug?
Debug mode is OFF
And after applied the patch, it'll be consistence(the "-d" option will take effect) :
[root@ha1 bin]# ./hbase shell -d
Setting DEBUG log level
......
hbase(main):001:0> debug?
Debug mode is ON
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd
behave the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485374#comment-13485374 ]
liang xie commented on HBASE-3925:
----------------------------------
[~saint.ack@gmail.com] Before i applied the patch, we could see :
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.96.0, 0.98.0
> Reporter: Lars George
> Assignee: liang xie
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-3925.patch, HBASE-3925-v2.txt
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3925) Make Shell's -d and debug cmd behave
the same
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liang xie updated HBASE-3925:
-----------------------------
Attachment: HBASE-3925.patch
a tentitive patch, please help to review, thanks:)
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
> Key: HBASE-3925
> URL: https://issues.apache.org/jira/browse/HBASE-3925
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.90.3
> Reporter: Lars George
> Priority: Trivial
> Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> end
> debug?
> end
> {noformat}
> could be something like
> {noformat}
> # Debugging method
> def debug
> if @shell.debug
> @shell.debug = false
> conf.back_trace_limit = 0
> log_level = org.apache.log4j.Level::ERROR
> else
> @shell.debug = true
> conf.back_trace_limit = 100
> log_level = org.apache.log4j.Level::DEBUG
> end
> org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
> org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
> debug?
> end
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira