[GitHub] [hudi] xushiyan commented on a change in pull request #3893: [HUDI-2656] Generalize HoodieIndex for flexible record data type

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #3893:
URL: https://github.com/apache/hudi/pull/3893#discussion_r790175359



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -466,7 +465,7 @@ private void acquireQPSResourcesAndSetBatchSize(final Option<Float> desiredQPSFr
     }
   }
 
-  public Tuple2<Long, Integer> getHBasePutAccessParallelism(final JavaRDD<WriteStatus> writeStatusRDD) {
+  Tuple2<Long, Integer> getHBasePutAccessParallelism(final JavaRDD<WriteStatus> writeStatusRDD) {

Review comment:
       ditto

##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -385,7 +384,7 @@ private void doMutations(BufferedMutator mutator, List<Mutation> mutations, Rate
     mutations.clear();
   }
 
-  public Map<String, Integer> mapFileWithInsertsToUniquePartition(JavaRDD<WriteStatus> writeStatusRDD) {
+  Map<String, Integer> mapFileWithInsertsToUniquePartition(JavaRDD<WriteStatus> writeStatusRDD) {

Review comment:
       this method only used in test; changing to package access due to using RDD in the signature

##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestSparkHoodieHBaseIndex.java
##########
@@ -16,15 +16,17 @@
  * limitations under the License.
  */
 
-package org.apache.hudi.client.functional;
+package org.apache.hudi.index.hbase;

Review comment:
       moved to the same package as `SparkHoodieHBaseIndex` so that some methods with RDD in the signature can be changed to package access




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org