You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 04:23:20 UTC

svn commit: r1181590 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java

Author: nspiegelberg
Date: Tue Oct 11 02:23:20 2011
New Revision: 1181590

URL: http://svn.apache.org/viewvc?rev=1181590&view=rev
Log:
fix unit test failures due to D274513

Summary:
D274513 added an incorrect overload of createWriter in StoreFile.Writer class--
an overload that was not using all its input arguments correctly.

Test Plan:
Ran the 4 failing unit tests, and they pass now.

mvntest TestCompoundBloomFilter
mvntest TestCacheOnWrite
mvntest TestScannerTimeout
mvntest TestHFileOutputFormat

Will kick off full mvn test suite run too.

Reviewed By: mbautin
Reviewers: mbautin, nileema, nspiegelberg
CC: , hbase@lists, mbautin
Differential Revision: 277151

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java?rev=1181590&r1=1181589&r2=1181590&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java Tue Oct 11 02:23:20 2011
@@ -564,9 +564,8 @@ public class StoreFile {
           BloomType bloomType,
           long maxKeyCount)
   throws IOException {
-	  return createWriter(fs, dir, blocksize, null, null, conf, BloomType.NONE,
-			  BloomFilterFactory.getErrorRate(conf), 0);
-
+      return createWriter(fs, dir, blocksize, algorithm, c, conf, bloomType,
+			  BloomFilterFactory.getErrorRate(conf), maxKeyCount);
   }
 
   /**