You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/10 20:31:49 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3898: [ISSUE #3897]Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer.
pandaapo opened a new pull request, #3898:
URL: https://github.com/apache/eventmesh/pull/3898
Fixes #3897.
### Motivation
See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/3897#issue-1704142309).
### Modifications
See "Describe the solution you'd like" in [issue](https://github.com/apache/eventmesh/issues/3897#issue-1704142309).
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3898: [ISSUE #3897]Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3898:
URL: https://github.com/apache/eventmesh/pull/3898#issuecomment-1547104729
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3898](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d4fcbc1) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/638edbe9209596b0649e8331f237b6a243a1621f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (638edbe) will **decrease** coverage by `0.04%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head d4fcbc1 differs from pull request most recent head 74cfe5a. Consider uploading reports for the commit 74cfe5a to get more accurate results
```diff
@@ Coverage Diff @@
## master #3898 +/- ##
============================================
- Coverage 13.93% 13.90% -0.04%
+ Complexity 1291 1287 -4
============================================
Files 570 570
Lines 28842 28824 -18
Branches 2807 2806 -1
============================================
- Hits 4019 4007 -12
+ Misses 24450 24443 -7
- Partials 373 374 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ventmesh/storage/rocketmq/admin/RocketMQAdmin.java](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9yb2NrZXRtcS9hZG1pbi9Sb2NrZXRNUUFkbWluLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...h/storage/rocketmq/admin/RocketMQAdminAdaptor.java](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9yb2NrZXRtcS9hZG1pbi9Sb2NrZXRNUUFkbWluQWRhcHRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...mesh/storage/standalone/admin/StandaloneAdmin.java](https://app.codecov.io/gh/apache/eventmesh/pull/3898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXN0YW5kYWxvbmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3N0YW5kYWxvbmUvYWRtaW4vU3RhbmRhbG9uZUFkbWluLmphdmE=) | `96.77% <100.00%> (+4.46%)` | :arrow_up: |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3898/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3898: [ISSUE #3897]Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3898:
URL: https://github.com/apache/eventmesh/pull/3898#issuecomment-1547005457
In consideration of current all CI error, you can try to review and merge this pr first if OK. @xwm1992
```
the following files are lack of license headers:
eventmesh-storage-plugin/eventmesh-storage-rocketmq/src/main/java/org/apache/eventmesh/storage/rocketmq/admin/AbstractRmqAdmin.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3898: [ISSUE #3897]Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3898:
URL: https://github.com/apache/eventmesh/pull/3898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org