You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "hiteshprajapati (via GitHub)" <gi...@apache.org> on 2023/02/22 15:12:15 UTC

[GitHub] [fineract] hiteshprajapati opened a new pull request, #3004: Fix for FINERACT-1895

hiteshprajapati opened a new pull request, #3004:
URL: https://github.com/apache/fineract/pull/3004

   fixing activemq config fix for in general notification
   
   ## Description
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] hiteshprajapati commented on pull request #3004: Fix for FINERACT-1895

Posted by "hiteshprajapati (via GitHub)" <gi...@apache.org>.
hiteshprajapati commented on PR #3004:
URL: https://github.com/apache/fineract/pull/3004#issuecomment-1448290213

   @galovics @vidakovic Please review this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] vidakovic commented on pull request #3004: Fix for FINERACT-1895

Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #3004:
URL: https://github.com/apache/fineract/pull/3004#issuecomment-1467680303

   @hiteshprajapati I'm not sure if I folllow entirely your changes... can you explain a bit why renaming is necessary, because I general I would say using interfaces is the way to go to be able to change concrete implementations... but maybe I am missing something here. Also: please make sure to name the PR like the other ones do... correct name would be "FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled"... then everyone knows what this is about and the linking in Jira is working properly... thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] hiteshprajapati closed pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled

Posted by "hiteshprajapati (via GitHub)" <gi...@apache.org>.
hiteshprajapati closed pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled
URL: https://github.com/apache/fineract/pull/3004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] vidakovic commented on a diff in pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled

Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on code in PR #3004:
URL: https://github.com/apache/fineract/pull/3004#discussion_r1136608489


##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@ fineract.tenant.description=${FINERACT_DEFAULT_TENANTDB_DESCRIPTION:Default Demo
 
 fineract.mode.read-enabled=${FINERACT_MODE_READ_ENABLED:true}
 fineract.mode.write-enabled=${FINERACT_MODE_WRITE_ENABLED:true}
+fineract.mode.batch-enabled=${FINERACT_MODE_BATCH_ENABLED:true}

Review Comment:
   @hiteshprajapati I am not so sure about this property here... why is it introduced if it's not used anywhere in your changes here? And if it's used in a different place: are we sure we want to set this by default to true? From what I can see here I don't think this property needs to be added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] hiteshprajapati commented on pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled

Posted by "hiteshprajapati (via GitHub)" <gi...@apache.org>.
hiteshprajapati commented on PR #3004:
URL: https://github.com/apache/fineract/pull/3004#issuecomment-1500884259

   @vidakovic : I will raise the new PR 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] hiteshprajapati closed pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled

Posted by "hiteshprajapati (via GitHub)" <gi...@apache.org>.
hiteshprajapati closed pull request #3004: FINERACT-1895: Fineract doesn't start with spring profile activeMqEnabled
URL: https://github.com/apache/fineract/pull/3004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org