You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ni...@apache.org on 2009/08/13 17:11:04 UTC
svn commit: r803924 - in /commons/sandbox/monitoring/trunk/core: pom.xml
src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java
Author: nicolas
Date: Thu Aug 13 15:11:04 2009
New Revision: 803924
URL: http://svn.apache.org/viewvc?rev=803924&view=rev
Log:
fix inconsistent min/max value in gauges
Modified:
commons/sandbox/monitoring/trunk/core/pom.xml
commons/sandbox/monitoring/trunk/core/src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java
Modified: commons/sandbox/monitoring/trunk/core/pom.xml
URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/core/pom.xml?rev=803924&r1=803923&r2=803924&view=diff
==============================================================================
--- commons/sandbox/monitoring/trunk/core/pom.xml (original)
+++ commons/sandbox/monitoring/trunk/core/pom.xml Thu Aug 13 15:11:04 2009
@@ -35,9 +35,9 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>commons-math</groupId>
+ <groupId>org.apache.commons</groupId>
<artifactId>commons-math</artifactId>
- <version>1.2</version>
+ <version>2.0</version>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
Modified: commons/sandbox/monitoring/trunk/core/src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java
URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/core/src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java?rev=803924&r1=803923&r2=803924&view=diff
==============================================================================
--- commons/sandbox/monitoring/trunk/core/src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java (original)
+++ commons/sandbox/monitoring/trunk/core/src/main/java/org/apache/commons/monitoring/metrics/ThreadSafeGauge.java Thu Aug 13 15:11:04 2009
@@ -27,6 +27,18 @@
protected Max max = new Max();
+ @Override
+ public double getMax()
+ {
+ return max.getResult();
+ }
+
+ @Override
+ public double getMin()
+ {
+ return min.getResult();
+ }
+
public ThreadSafeGauge( Role role )
{
super( role );
@@ -106,8 +118,8 @@
getSummary().addValue( s );
}
lastUse = now;
- min.increment( d );
- max.increment( d );
+ min.increment( value );
+ max.increment( value );
}
@Override