You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2025/04/01 12:59:49 UTC
[PR] feat: make some helpers/utils public [arrow-rs-object-store]
crepererum opened a new pull request, #316:
URL: https://github.com/apache/arrow-rs-object-store/pull/316
# Which issue does this PR close?
\-
# Rationale for this change
Makes it easier to implement out-of-tree / 3rd-party stores w/o replicating the code.
# What changes are included in this PR?
- public `GetRange` helpers
- public `GetOptions::check_precondition`
# Are there any user-facing changes?
More public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: make some helpers/utils public [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #316:
URL: https://github.com/apache/arrow-rs-object-store/pull/316#discussion_r2040702270
##########
src/util.rs:
##########
@@ -208,7 +208,8 @@ pub enum GetRange {
}
#[derive(Debug, thiserror::Error)]
-pub(crate) enum InvalidGetRange {
+#[expect(missing_copy_implementations)] // allow easier extension
Review Comment:
Might also want non_exhaustive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: make some helpers/utils public [arrow-rs-object-store]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum merged PR #316:
URL: https://github.com/apache/arrow-rs-object-store/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org