You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "jnturton (via GitHub)" <gi...@apache.org> on 2023/03/16 12:31:50 UTC
[PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
jnturton opened a new pull request, #2776:
URL: https://github.com/apache/drill/pull/2776
# [DRILL-8412](https://issues.apache.org/jira/browse/DRILL-8412): Upgrade to Calcite 1.35-SNAPSHOT
## Description
If we're willing to try basing Drill master on snapshot builds of the upcoming version of Calcite for a while then here's a PR to do that. Please see the related discussion in Drill and Calcite mailing lists this week for more information.
Important notes.
1. The CI tests that run automatically upon commits to Drill master will exercise Drill with present day Calcite.
2. Breaking changes in Calcite would (mostly) break the Drill CI and force us to deal with them in order to proceed.
3. Regressions in Calcite would (mostly) break the Drill CI and force to report them in order to proceed.
4. If Drill master becomes too unstable when it is based on Calcite snapshots then this PR is trivially undoable.
## Documentation
N/A
## Testing
Existing unit test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2776:
URL: https://github.com/apache/drill/pull/2776#issuecomment-1496047719
Can someone do the formailty of approving so that we can give this a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton merged PR #2776:
URL: https://github.com/apache/drill/pull/2776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2776:
URL: https://github.com/apache/drill/pull/2776#issuecomment-1476706574
@jnturton I think we should definitely run this experiment. I'm also curious as to how to run this with a specific PR from Calcite. That way I can contribute to the review process over there and find things that break drill quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2776:
URL: https://github.com/apache/drill/pull/2776#issuecomment-1475747749
@cgivre, @vvysotskyi, @rymarm, @luocooong are you up for running this experiment for a while? It's trivial to revert but I personally feel there's a good chance that we won't want to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8412: Upgrade to Calcite 1.35-SNAPSHOT (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2776:
URL: https://github.com/apache/drill/pull/2776#issuecomment-1476733563
> @jnturton I think we should definitely run this experiment. I'm also curious as to how to run this with a specific PR from Calcite. That way I can contribute to the review process over there and find things that break drill quickly.
They won't build and publish artefacts for unmerged PRs (would be a security problem) so we'll have to run our own Calcite builds for these. Probably the best is for the developer to pull the PR into a local branch and build Calcite putting the results in their local Maven repo, then build Drill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org