[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5889: Clean up SortExec creation and add doc comments

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5889:
URL: https://github.com/apache/arrow-datafusion/pull/5889#discussion_r1159021284


##########
datafusion/core/src/physical_optimizer/sort_enforcement.rs:
##########
@@ -1220,12 +1220,10 @@ mod tests {
             sort_expr("non_nullable_col", &schema),
         ];
         let repartition_exec = repartition_exec(spm);
-        let sort2 = Arc::new(SortExec::new_with_partitioning(
-            sort_exprs.clone(),
-            repartition_exec,
-            true,
-            None,
-        )) as _;
+        let sort2 = Arc::new(
+            SortExec::new(sort_exprs.clone(), repartition_exec, None)
+                .with_preserve_partitioning(true),

Review Comment:
   I think this makes it clearer that the sort is being constructed to  preserve the input partitioning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org