You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:43 UTC
[GitHub] [kafka] chia7712 commented on a change in pull request #7641: MINOR: Add a unit test for GroupMetadataManager#offsetExpiredSensor
chia7712 commented on a change in pull request #7641:
URL: https://github.com/apache/kafka/pull/7641#discussion_r516399560
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -791,52 +797,52 @@ class GroupMetadataManager(brokerId: Int,
(removedOffsets, group.is(Dead), group.generationId)
}
- val offsetsPartition = partitionFor(groupId)
- val appendPartition = new TopicPartition(Topic.GROUP_METADATA_TOPIC_NAME, offsetsPartition)
- getMagic(offsetsPartition) match {
- case Some(magicValue) =>
- // We always use CREATE_TIME, like the producer. The conversion to LOG_APPEND_TIME (if necessary) happens automatically.
- val timestampType = TimestampType.CREATE_TIME
- val timestamp = time.milliseconds()
+ val offsetsPartition = partitionFor(groupId)
Review comment:
make senses to me. Could you fix the conflicting files?
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -791,52 +797,52 @@ class GroupMetadataManager(brokerId: Int,
(removedOffsets, group.is(Dead), group.generationId)
}
- val offsetsPartition = partitionFor(groupId)
- val appendPartition = new TopicPartition(Topic.GROUP_METADATA_TOPIC_NAME, offsetsPartition)
- getMagic(offsetsPartition) match {
- case Some(magicValue) =>
- // We always use CREATE_TIME, like the producer. The conversion to LOG_APPEND_TIME (if necessary) happens automatically.
- val timestampType = TimestampType.CREATE_TIME
- val timestamp = time.milliseconds()
+ val offsetsPartition = partitionFor(groupId)
Review comment:
make sense to me. Could you fix the conflicting files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org