Re: [PR] feat: Add support for SpiderMonkey v140 [couchdb]

["ZaWertun (via GitHub)" <gi...@apache.org>]

ZaWertun commented on PR #5677:
URL: https://github.com/apache/couchdb/pull/5677#issuecomment-4799167715

   When running CouchJS compiled with MozJS 140 - it will crash on this line with SIGSEGV (exit code 139):
   ```C++
   deep = args[1].toBoolean();
   ```
   
   Stack trace:
   ```C++
   #0  0x00000000004010a8 in MOZ_CrashSequence (aAddress=0x0, aLine=213) at /usr/include/mozjs-140/mozilla/Assertions.h:248
   #1  0x0000000000403b53 in JS::detail::CallArgsBase<JS::detail::IncludeUsedRval>::operator[] (this=0x7ffc366823b0, i=1) at /usr/include/mozjs-140/js/CallArgs.h:213
   #2  0x0000000000402098 in seal (cx=0x2b1f21e0, argc=1, vp=0x2b2cbfb0) at /home/zawertun/tmp/couchjs-standalone/src/140/main.cpp:210
   ```
   
   It could be fixed as followed:
   ```C++
   bool deep = args.hasDefined(1) && JS::ToBoolean(args[1]);
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org