You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/15 14:14:23 UTC
[GitHub] [dubbo] XIACYBING opened a new pull request #8817: Triple transmission supports message compression
XIACYBING opened a new pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817
## What is the purpose of the change
Support payload compression in the triple protocol
## Brief changelog
Triple transmission supports message compression
## Verifying this change
Yes
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3577230) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f561138fe92cc838146b76479fdff70ab163401d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f561138) will **decrease** coverage by `0.09%`.
> The diff coverage is `70.83%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.38% 63.28% -0.10%
Complexity 314 314
============================================
Files 1186 1188 +2
Lines 50358 50442 +84
Branches 7525 7532 +7
============================================
+ Hits 31920 31923 +3
- Misses 14957 15026 +69
- Partials 3481 3493 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.39% <54.54%> (+1.37%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.07% <63.63%> (+5.51%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.13% <83.33%> (+1.35%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.73% <100.00%> (+1.66%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `53.92% <100.00%> (+2.37%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `61.76% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f561138...3577230](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r716416714
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -155,7 +160,11 @@ protected Metadata createRequestMeta(RpcInvocation inv) {
(String) inv.getObjectAttachments().remove(CommonConstants.APPLICATION_KEY))
.putIfNotNull(TripleHeaderEnum.CONSUMER_APP_NAME_KEY.getHeader(),
(String) inv.getObjectAttachments().remove(CommonConstants.REMOTE_APPLICATION_KEY))
- .putIfNotNull(TripleHeaderEnum.SERVICE_GROUP.getHeader(), inv.getInvoker().getUrl().getGroup());
+ .putIfNotNull(TripleHeaderEnum.SERVICE_GROUP.getHeader(), inv.getInvoker().getUrl().getGroup())
+ .putIfNotNull(TripleHeaderEnum.GRPC_ENCODING.getHeader(),
+ ConfigurationUtils.getGlobalConfiguration(ApplicationModel.defaultModel()).getString(Constants.COMPRESSOR_KEY, DEFAULT_COMPRESSOR))
Review comment:
plz Obtain the configuration in multi-instance mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XIACYBING commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
XIACYBING commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-921038612
> the server always put all encodings in header
yes, we did like that
> the server always put all encodings in header `https://github.com/grpc/grpc-java/blob/3b237339c7b0b5e60b6331cac9e23650e97b1e8c/core/src/main/java/io/grpc/internal/ServerCallImpl.java#sendHeadersInternal`
yes，it is what we did > `org.apache.dubbo.rpc.protocol.tri.AbstractServerStream#createRequestMeta`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e6f58c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1702fa0abb2c9f421d88593b0c0f6206e1a86d6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1702fa0) will **decrease** coverage by `0.05%`.
> The diff coverage is `70.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.74% 63.69% -0.06%
- Complexity 313 314 +1
============================================
Files 1169 1171 +2
Lines 49210 49293 +83
Branches 7360 7367 +7
============================================
+ Hits 31370 31396 +26
- Misses 14412 14459 +47
- Partials 3428 3438 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `42.63% <54.54%> (+1.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `46.00% <63.63%> (+4.97%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `47.50% <83.33%> (+1.39%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `66.66% <100.00%> (+1.73%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `56.31% <100.00%> (+2.22%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1702fa0...4e6f58c](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e6f58c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1702fa0abb2c9f421d88593b0c0f6206e1a86d6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1702fa0) will **decrease** coverage by `0.13%`.
> The diff coverage is `70.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.74% 63.61% -0.14%
Complexity 313 313
============================================
Files 1169 1171 +2
Lines 49210 49255 +45
Branches 7360 7338 -22
============================================
- Hits 31370 31333 -37
- Misses 14412 14478 +66
- Partials 3428 3444 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `42.63% <54.54%> (+1.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `46.00% <63.63%> (+4.97%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `47.50% <83.33%> (+1.39%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `66.66% <100.00%> (+1.73%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `56.31% <100.00%> (+2.22%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [54 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1702fa0...4e6f58c](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e6f58c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1702fa0abb2c9f421d88593b0c0f6206e1a86d6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1702fa0) will **increase** coverage by `0.04%`.
> The diff coverage is `70.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
+ Coverage 63.74% 63.79% +0.04%
- Complexity 313 315 +2
============================================
Files 1169 1171 +2
Lines 49210 49293 +83
Branches 7360 7367 +7
============================================
+ Hits 31370 31446 +76
- Misses 14412 14416 +4
- Partials 3428 3431 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `42.63% <54.54%> (+1.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `46.00% <63.63%> (+4.97%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `47.50% <83.33%> (+1.39%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `66.66% <100.00%> (+1.73%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `56.31% <100.00%> (+2.22%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1702fa0...4e6f58c](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XIACYBING commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
XIACYBING commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-932786633
> For streams, we should also support full stream compression.
it will support in the another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3577230) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f561138fe92cc838146b76479fdff70ab163401d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f561138) will **decrease** coverage by `0.03%`.
> The diff coverage is `70.83%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.38% 63.35% -0.04%
- Complexity 314 315 +1
============================================
Files 1186 1188 +2
Lines 50358 50442 +84
Branches 7525 7532 +7
============================================
+ Hits 31920 31958 +38
- Misses 14957 14995 +38
- Partials 3481 3489 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.39% <54.54%> (+1.37%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.07% <63.63%> (+5.51%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.13% <83.33%> (+1.35%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.73% <100.00%> (+1.66%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `53.92% <100.00%> (+2.37%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `61.76% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f561138...3577230](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
plusmancn commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r709800319
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHeaderEnum.java
##########
@@ -35,6 +35,8 @@
CONTENT_TYPE_KEY("content-type"),
CONTENT_PROTO("application/grpc+proto"),
APPLICATION_GRPC("application/grpc"),
+ GRPC_ENCODING("grpc-encoding"),
+ GRPC_ACCEPT_ENCODING("grpc-accept-encoding"),
TRICE_ID_KEY("tri-trace-traceid"),
Review comment:
Better to replace it with the `tri-*` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-920557737
the server always put all encodings in header `https://github.com/grpc/grpc-java/blob/3b237339c7b0b5e60b6331cac9e23650e97b1e8c/core/src/main/java/io/grpc/internal/ServerCallImpl.java#sendHeadersInternal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922170582
For streams, we should also support full stream compression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-920547642
plz fix ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r716421802
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientHandler.java
##########
@@ -90,6 +95,13 @@ private void writeRequest(ChannelHandlerContext ctx, final Request req, final Ch
if (StringUtils.isNotEmpty(ssl)) {
ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).set(Boolean.parseBoolean(ssl));
}
+
+ // get compressor
+ String compressorStr = ConfigurationUtils.getGlobalConfiguration(ApplicationModel.defaultModel()).getString(COMPRESSOR_KEY, DEFAULT_COMPRESSOR);
Review comment:
Obtain the configuration in multi-instance mode from url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e6f58c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1702fa0abb2c9f421d88593b0c0f6206e1a86d6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1702fa0) will **increase** coverage by `0.04%`.
> The diff coverage is `70.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
+ Coverage 63.74% 63.79% +0.04%
- Complexity 313 315 +2
============================================
Files 1169 1171 +2
Lines 49210 49293 +83
Branches 7360 7367 +7
============================================
+ Hits 31370 31447 +77
- Misses 14412 14415 +3
- Partials 3428 3431 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `42.63% <54.54%> (+1.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `46.00% <63.63%> (+4.97%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `47.50% <83.33%> (+1.39%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `66.66% <100.00%> (+1.73%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `56.31% <100.00%> (+2.22%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1702fa0...4e6f58c](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XIACYBING commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
XIACYBING commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r720704603
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -155,7 +160,11 @@ protected Metadata createRequestMeta(RpcInvocation inv) {
(String) inv.getObjectAttachments().remove(CommonConstants.APPLICATION_KEY))
.putIfNotNull(TripleHeaderEnum.CONSUMER_APP_NAME_KEY.getHeader(),
(String) inv.getObjectAttachments().remove(CommonConstants.REMOTE_APPLICATION_KEY))
- .putIfNotNull(TripleHeaderEnum.SERVICE_GROUP.getHeader(), inv.getInvoker().getUrl().getGroup());
+ .putIfNotNull(TripleHeaderEnum.SERVICE_GROUP.getHeader(), inv.getInvoker().getUrl().getGroup())
+ .putIfNotNull(TripleHeaderEnum.GRPC_ENCODING.getHeader(),
+ ConfigurationUtils.getGlobalConfiguration(ApplicationModel.defaultModel()).getString(Constants.COMPRESSOR_KEY, DEFAULT_COMPRESSOR))
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XIACYBING edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
XIACYBING edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-921038612
> the server always put all encodings in header `https://github.com/grpc/grpc-java/blob/3b237339c7b0b5e60b6331cac9e23650e97b1e8c/core/src/main/java/io/grpc/internal/ServerCallImpl.java#sendHeadersInternal`
yes，it is what we did > `org.apache.dubbo.rpc.protocol.tri.AbstractServerStream#createRequestMeta`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw commented on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-920761052
> plz fix ut
you might builld it again because some wrong codes were merged into 3.0 but they are fixed by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3577230) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f561138fe92cc838146b76479fdff70ab163401d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f561138) will **decrease** coverage by `0.00%`.
> The diff coverage is `70.83%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.38% 63.37% -0.01%
- Complexity 314 315 +1
============================================
Files 1186 1188 +2
Lines 50358 50442 +84
Branches 7525 7532 +7
============================================
+ Hits 31920 31970 +50
- Misses 14957 14984 +27
- Partials 3481 3488 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.39% <54.54%> (+1.37%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.07% <63.63%> (+5.51%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.13% <83.33%> (+1.35%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.73% <100.00%> (+1.66%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `53.92% <100.00%> (+2.37%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `61.76% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f561138...3577230](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-922168005
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8817](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3577230) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f561138fe92cc838146b76479fdff70ab163401d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f561138) will **decrease** coverage by `0.16%`.
> The diff coverage is `70.83%`.
[](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8817 +/- ##
============================================
- Coverage 63.38% 63.21% -0.17%
+ Complexity 314 311 -3
============================================
Files 1186 1188 +2
Lines 50358 50406 +48
Branches 7525 7505 -20
============================================
- Hits 31920 31865 -55
- Misses 14957 15037 +80
- Partials 3481 3504 +23
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/rpc/protocol/tri/GrpcDataDecoder.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY0RhdGFEZWNvZGVyLmphdmE=) | `48.57% <33.33%> (+0.18%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.39% <54.54%> (+1.37%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/GzipCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3ppcENvbXByZXNzb3IuamF2YQ==) | `60.86% <60.86%> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `42.85% <62.50%> (+0.98%)` | :arrow_up: |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.07% <63.63%> (+5.51%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.13% <83.33%> (+1.35%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.73% <100.00%> (+1.66%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `53.92% <100.00%> (+2.37%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `61.76% <100.00%> (ø)` | |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/dubbo/pull/8817/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f561138...3577230](https://codecov.io/gh/apache/dubbo/pull/8817?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XIACYBING commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
XIACYBING commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r720704585
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/Compressor.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc.protocol.tri;
+
+import org.apache.dubbo.common.extension.SPI;
+import org.apache.dubbo.rpc.Constants;
+
+import static org.apache.dubbo.rpc.protocol.tri.Compressor.DEFAULT_COMPRESSOR;
+
+/**
+ * compress payload for grpc request， and decompress response payload
+ * Configure it in files, pictures or other configurations that exist in the system properties
+ * Configure {@link Constants#COMPRESSOR_KEY} in dubbo.properties、dubbo.yml or other configuration that exist in the system property
+ */
+@SPI(DEFAULT_COMPRESSOR)
Review comment:
done
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientHandler.java
##########
@@ -90,6 +95,13 @@ private void writeRequest(ChannelHandlerContext ctx, final Request req, final Ch
if (StringUtils.isNotEmpty(ssl)) {
ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).set(Boolean.parseBoolean(ssl));
}
+
+ // get compressor
+ String compressorStr = ConfigurationUtils.getGlobalConfiguration(ApplicationModel.defaultModel()).getString(COMPRESSOR_KEY, DEFAULT_COMPRESSOR);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a change in pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
EarthChen commented on a change in pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#discussion_r716419202
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/Compressor.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc.protocol.tri;
+
+import org.apache.dubbo.common.extension.SPI;
+import org.apache.dubbo.rpc.Constants;
+
+import static org.apache.dubbo.rpc.protocol.tri.Compressor.DEFAULT_COMPRESSOR;
+
+/**
+ * compress payload for grpc request， and decompress response payload
+ * Configure it in files, pictures or other configurations that exist in the system properties
+ * Configure {@link Constants#COMPRESSOR_KEY} in dubbo.properties、dubbo.yml or other configuration that exist in the system property
+ */
+@SPI(DEFAULT_COMPRESSOR)
Review comment:
plz set `scope = ExtensionScope.FRAMEWORK)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw edited a comment on pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817#issuecomment-920761052
> plz fix ut
you might build it again because some wrong codes were merged into 3.0 but they are fixed by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao merged pull request #8817: Triple transmission supports message compression
Posted by GitBox <gi...@apache.org>.
guohao merged pull request #8817:
URL: https://github.com/apache/dubbo/pull/8817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org