You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/04/19 23:49:37 UTC
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10130
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
[iwyu] minor cleanup after LLVM/IWYU update
It seems IWYU started output some new warning since LLVM/IWYU was
upgraded recently. I found that while looking at IWYU warnings output
while processing HMS-related code. This small update cleans up
all warnings from all files we currently check with IWYU tool.
As an additional update, I switched client/error-internal.{cc,h}
from gscoped_ptr to std::unique_ptr.
This changelist does not contain any functional changes.
Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client.cc
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/server/rpc_server.cc
M src/kudu/server/server_base.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/callback_bind-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/env.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/once.h
M src/kudu/util/trace_metrics.h
63 files changed, 25 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/10130/1
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10130/1/src/kudu/rpc/negotiation-test.cc
File src/kudu/rpc/negotiation-test.cc:
http://gerrit.cloudera.org:8080/#/c/10130/1/src/kudu/rpc/negotiation-test.cc@53
PS1, Line 53: #include "kudu/security/security_flags.h"
nit: trailing space
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 00:29:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
Patch Set 2:
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/13056/ : FAILURE
Heh, that's strange -- IWYU produced some other warnings which I didn't see at ve0518
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 03:41:22 +0000
Gerrit-HasComments: No
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
[iwyu] minor cleanup after LLVM/IWYU update
It seems IWYU started output some new warning since LLVM/IWYU was
upgraded recently. I found that while looking at IWYU warnings output
while processing HMS-related code. This small update cleans up
all warnings from all files we currently check with IWYU tool.
As an additional update, I switched client/error-internal.{cc,h}
from gscoped_ptr to std::unique_ptr.
This changelist does not contain any functional changes.
Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Reviewed-on: http://gerrit.cloudera.org:8080/10130
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client.cc
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/security/tls_context.h
M src/kudu/server/rpc_server.cc
M src/kudu/server/server_base.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/callback_bind-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/env.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/once.h
M src/kudu/util/trace_metrics.h
65 files changed, 28 insertions(+), 72 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10130
to look at the new patch set (#2).
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
[iwyu] minor cleanup after LLVM/IWYU update
It seems IWYU started output some new warning since LLVM/IWYU was
upgraded recently. I found that while looking at IWYU warnings output
while processing HMS-related code. This small update cleans up
all warnings from all files we currently check with IWYU tool.
As an additional update, I switched client/error-internal.{cc,h}
from gscoped_ptr to std::unique_ptr.
This changelist does not contain any functional changes.
Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client.cc
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/security/tls_context.h
M src/kudu/server/rpc_server.cc
M src/kudu/server/server_base.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/callback_bind-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/env.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/once.h
M src/kudu/util/trace_metrics.h
65 files changed, 28 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/10130/2
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
Patch Set 2: Verified+1
All right, I would consider this IWYU strangeness as something I need to investigate.
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 04:36:08 +0000
Gerrit-HasComments: No
[kudu-CR] [iwyu] minor cleanup after LLVM/IWYU update
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10130 )
Change subject: [iwyu] minor cleanup after LLVM/IWYU update
......................................................................
Patch Set 2: Code-Review+2
Carrying over Todd's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/10130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Gerrit-Change-Number: 10130
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 04:36:36 +0000
Gerrit-HasComments: No