You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by haoch <gi...@git.apache.org> on 2016/10/12 09:08:34 UTC
[GitHub] incubator-eagle pull request #495: EAGLE-613 Support modify ApplicationEntit...
GitHub user haoch opened a pull request:
https://github.com/apache/incubator-eagle/pull/495
EAGLE-613 Support modify ApplicationEntity through POST /rest/apps/{UUID}/
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/incubator-eagle EAGLE-613
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #495
----
commit 050fc53c9743d0e9636d6b0d889bc400347857da
Author: Hao Chen <ha...@apache.org>
Date: 2016-10-12T08:44:16Z
Support modify ApplicationEntity API
commit 04c8ab98185a0d5119073ac86f70e09aa81dfed4
Author: Hao Chen <ha...@apache.org>
Date: 2016-10-12T09:07:06Z
Add UpdateOperation for updating ApplicationEntity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #495: EAGLE-613 Support modify ApplicationEntit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #495: EAGLE-613 Support modify ApplicationEntit...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/495#discussion_r82965523
--- Diff: eagle-core/eagle-metadata/eagle-metadata-jdbc/src/main/java/org/apache/eagle/metadata/store/jdbc/service/ApplicationEntityServiceJDBCImpl.java ---
@@ -116,6 +116,14 @@ public ApplicationEntity delete(ApplicationEntity applicationEntity) {
return entity;
}
+ /**
+ * TODO: UPDATE ApplicationEntity through JDBC is not supported yet
+ */
+ @Override
+ public ApplicationEntity update(ApplicationEntity entity) {
+ throw new UnsupportedOperationException("UPDATE ApplicationEntity through JDBC is not supported yet");
--- End diff --
@r7raul1984 Could you please implement updating operation for JDBC metadata store?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #495: EAGLE-613 Support modify ApplicationEntity throu...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/495
@zombieJ
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---