You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by praveenmeenakshi56 <gi...@git.apache.org> on 2018/04/11 08:50:04 UTC
[GitHub] carbondata pull request #2157: [CARBONDATA-2334] Added Property enabling use...
GitHub user praveenmeenakshi56 opened a pull request:
https://github.com/apache/carbondata/pull/2157
[CARBONDATA-2334] Added Property enabling user to block partitioning of Pre-Aggregate t…
While creating PreAgg table, in DMPROPERTIES, 'partitioning'='false' will disable partitioning of the Pre-Aggregate table
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/praveenmeenakshi56/carbondata part_block
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2157
----
commit ac8e4db6fd1371ac0f28d0a9dc0b964de6a4e1d9
Author: praveenmeenakshi56 <pr...@...>
Date: 2018-04-11T08:43:14Z
Added Property enabling user to block partitioning of Pre-Aggregate table
----
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3846/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5092/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4941/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2157
LGTM
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3850/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5068/
---
[GitHub] carbondata pull request #2157: [CARBONDATA-2334] Added Property enabling use...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2157
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3946/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by praveenmeenakshi56 <gi...@git.apache.org>.
Github user praveenmeenakshi56 commented on the issue:
https://github.com/apache/carbondata/pull/2157
retest this please
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3872/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by praveenmeenakshi56 <gi...@git.apache.org>.
Github user praveenmeenakshi56 commented on the issue:
https://github.com/apache/carbondata/pull/2157
retest this please
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5072/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3879/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2157
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4424/
---
[GitHub] carbondata pull request #2157: [CARBONDATA-2334] Added Property enabling use...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2157#discussion_r181696200
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -67,7 +67,10 @@ case class PreAggregateTableHelper(
val partitionInfo = parentTable.getPartitionInfo
val fields = fieldRelationMap.keySet.toSeq
val tableProperties = mutable.Map[String, String]()
- val parentPartitionColumns = if (parentTable.isHivePartitionTable) {
+ val usePartitioning = dataMapProperties.getOrDefault("partitioning", "true").toBoolean
+ val parentPartitionColumns = if (!usePartitioning) {
+ Seq()
--- End diff --
change to Seq.empty
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by praveenmeenakshi56 <gi...@git.apache.org>.
Github user praveenmeenakshi56 commented on the issue:
https://github.com/apache/carbondata/pull/2157
retest this please
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5086/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3722/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3862/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4972/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5101/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4986/
---
[GitHub] carbondata issue #2157: [CARBONDATA-2334] Added Property enabling user to bl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2157
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5156/
---