You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Jennifer A Thompson (Created) (JIRA)" <de...@tuscany.apache.org> on 2012/01/23 16:43:41 UTC

[jira] [Created] (TUSCANY-4008) operationProperties "selectedOperation" element not selecting the correct operation

operationProperties "selectedOperation" element not selecting the correct operation
-----------------------------------------------------------------------------------

                 Key: TUSCANY-4008
                 URL: https://issues.apache.org/jira/browse/TUSCANY-4008
             Project: Tuscany
          Issue Type: Bug
          Components: Java SCA JMS Binding Extension
    Affects Versions: Java-SCA-2.x
            Reporter: Jennifer A Thompson
             Fix For: Java-SCA-2.x


the operationProperties "selectedOperation" element is not selecting the correct operation when specified in a .composite file. For example:

<operationProperties name="subtract" selectedOperation="proxyOpName" />

Following the rules of operation selection, the operation selector determined the operation should be "proxyOpName", but even though the opertionProperties element was specified to have subtract be invoked, the code actually invoked proxyOpName. 

Debugged revealed the code was recognizing that a native operation should be updated, but it was retrieving the wrong information. JMSBinding.nativeOperationNames map is essentially "backwards" from what we actually want to retrieve (it was retrieving the native operation rather than the opName). So I've created a patch which create a new table mapping native operation -> opName, and updated the code as appropriate. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TUSCANY-4008) operationProperties "selectedOperation" element not selecting the correct operation

Posted by "ant elder (Assigned) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ant elder reassigned TUSCANY-4008:
----------------------------------

    Assignee: ant elder
    
> operationProperties "selectedOperation" element not selecting the correct operation
> -----------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4008
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4008
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>            Assignee: ant elder
>             Fix For: Java-SCA-2.x
>
>         Attachments: selectedOperation.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> the operationProperties "selectedOperation" element is not selecting the correct operation when specified in a .composite file. For example:
> <operationProperties name="subtract" selectedOperation="proxyOpName" />
> Following the rules of operation selection, the operation selector determined the operation should be "proxyOpName", but even though the opertionProperties element was specified to have subtract be invoked, the code actually invoked proxyOpName. 
> Debugged revealed the code was recognizing that a native operation should be updated, but it was retrieving the wrong information. JMSBinding.nativeOperationNames map is essentially "backwards" from what we actually want to retrieve (it was retrieving the native operation rather than the opName). So I've created a patch which create a new table mapping native operation -> opName, and updated the code as appropriate. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TUSCANY-4008) operationProperties "selectedOperation" element not selecting the correct operation

Posted by "Jennifer A Thompson (Updated) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jennifer A Thompson updated TUSCANY-4008:
-----------------------------------------

    Attachment: selectedOperation.patch
    
> operationProperties "selectedOperation" element not selecting the correct operation
> -----------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4008
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4008
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>             Fix For: Java-SCA-2.x
>
>         Attachments: selectedOperation.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> the operationProperties "selectedOperation" element is not selecting the correct operation when specified in a .composite file. For example:
> <operationProperties name="subtract" selectedOperation="proxyOpName" />
> Following the rules of operation selection, the operation selector determined the operation should be "proxyOpName", but even though the opertionProperties element was specified to have subtract be invoked, the code actually invoked proxyOpName. 
> Debugged revealed the code was recognizing that a native operation should be updated, but it was retrieving the wrong information. JMSBinding.nativeOperationNames map is essentially "backwards" from what we actually want to retrieve (it was retrieving the native operation rather than the opName). So I've created a patch which create a new table mapping native operation -> opName, and updated the code as appropriate. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TUSCANY-4008) operationProperties "selectedOperation" element not selecting the correct operation

Posted by "ant elder (Closed) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ant elder closed TUSCANY-4008.
------------------------------

    Resolution: Fixed

Patch applied, thanks for the fix Jennifer. 
I did also have to update the JMS selectors itest which was using this function so needed to be updated to match.
                
> operationProperties "selectedOperation" element not selecting the correct operation
> -----------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4008
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4008
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>            Assignee: ant elder
>             Fix For: Java-SCA-2.x
>
>         Attachments: selectedOperation.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> the operationProperties "selectedOperation" element is not selecting the correct operation when specified in a .composite file. For example:
> <operationProperties name="subtract" selectedOperation="proxyOpName" />
> Following the rules of operation selection, the operation selector determined the operation should be "proxyOpName", but even though the opertionProperties element was specified to have subtract be invoked, the code actually invoked proxyOpName. 
> Debugged revealed the code was recognizing that a native operation should be updated, but it was retrieving the wrong information. JMSBinding.nativeOperationNames map is essentially "backwards" from what we actually want to retrieve (it was retrieving the native operation rather than the opName). So I've created a patch which create a new table mapping native operation -> opName, and updated the code as appropriate. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira