[jira] [Commented] (SQOOP-2446) Sqoop2: Fix incorrect notification URL for execution engine

["Dian Fu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661464#comment-14661464 ] 

Dian Fu commented on SQOOP-2446:
--------------------------------

Hi [~jarcec],

The patch LGTM with only one minor exception:
{quote}
// Current approach is to point JobManager to use /v1/job/notification/$JOB_ID/status
{quote}
It should be {{/v1/job/$JOB_ID/status}}

> Sqoop2: Fix incorrect notification URL for execution engine
> -----------------------------------------------------------
>
>                 Key: SQOOP-2446
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2446
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2446.patch
>
>
> While looking into the {{NullPointerException}} in SQOOP-2439 I've noticed that we've changed the REST interface in incompatible way without changing the notification URL accordingly.
> The original way was to use {{job/status/$ID}} whereas the new format is {{job/$ID/status}}. We should change the notification URL accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)